Convert the toolbar in Widgets screen to ARIA toolbar #25111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| showInserterHelpPanel | ||
| toggleProps={ { | ||
| ...inserterToggleProps, | ||
| ...toolbarItemProps, |
There was a problem hiding this comment.
This also includes ref, which will pass to the toggle button in <Inserter>
Comment on lines 9 to 27
| .edit-widgets-header-toolbar { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| border: none; | ||
| // The Toolbar component adds different styles to buttons, so we reset them | ||
| // here to the original button styles | ||
| > .components-button.has-icon, | ||
| > .components-dropdown > .components-button.has-icon { | ||
| height: $button-size; | ||
| min-width: $button-size; | ||
| padding: 6px; | ||
| &.is-pressed { | ||
| background: $gray-900; | ||
| } | ||
| &:focus:not(:disabled) { | ||
| box-shadow: | ||
| 0 0 0 $border-width-focus var(--wp-admin-theme-color), | ||
| inset 0 0 0 $border-width $white; | ||
| outline: 1px solid transparent; | ||
| } | ||
| &::before { | ||
| display: none; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
These are mostly copied from edit-post/header-toolbar
kevin940726 added [Feature] Widgets Screen 
Size Change: +322 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
kevin940726 force-pushed the update/edit-widgets-aria-toolbar branch from 5588637 to 6cc9a6a Compare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fix #24938.
Convert the toolbar in Widgets screen from menu to toolbar, and make them accessible.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: