Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Limit the block slash inserter to 9 items and show most used by default #25113

Merged
merged 4 commits into from Sep 9, 2020
Merged

Limit the block slash inserter to 9 items and show most used by default #25113

merged 4 commits into from Sep 9, 2020

Conversation

youknowriad
Copy link
Contributor

This PR limits the block autocompleter to 6 items and default to the most used blocks by default.

@youknowriad youknowriad self-assigned this Sep 7, 2020
@youknowriad youknowriad added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. labels Sep 7, 2020
@github-actions
Copy link

github-actions bot commented Sep 7, 2020 •
edited

Size Change: +2.92 kB (0%)

Total Size: 1.2 MB

Filename Size Change
build/a11y/index.js 1.14 kB +1 B
build/annotations/index.js 3.67 kB +2 B (0%)
build/autop/index.js 2.82 kB +1 B
build/block-directory/index.js 8.5 kB +1 B
build/block-editor/index.js 128 kB +24 B (0%)
build/block-editor/style-rtl.css 11.1 kB -45 B (0%)
build/block-editor/style.css 11.1 kB -47 B (0%)
build/block-library/editor-rtl.css 8.68 kB +43 B (0%)
build/block-library/editor.css 8.68 kB +44 B (0%)
build/block-library/index.js 139 kB +550 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB +1 B
build/blocks/index.js 47.7 kB -3 B (0%)
build/components/index.js 200 kB -95 B (0%)
build/compose/index.js 9.68 kB +3 B (0%)
build/data-controls/index.js 1.29 kB -3 B (0%)
build/data/index.js 8.54 kB -3 B (0%)
build/edit-navigation/index.js 11.7 kB +49 B (0%)
build/edit-post/index.js 305 kB +62 B (0%)
build/edit-site/index.js 19.4 kB +2.26 kB (11%) ⚠️
build/edit-widgets/index.js 12.1 kB +60 B (0%)
build/editor/index.js 45.6 kB +6 B (0%)
build/element/index.js 4.64 kB -2 B (0%)
build/format-library/index.js 7.72 kB +3 B (0%)
build/keyboard-shortcuts/index.js 2.52 kB +3 B (0%)
build/keycodes/index.js 1.95 kB +1 B
build/list-reusable-blocks/index.js 3.12 kB +1 B
build/notices/index.js 1.79 kB -2 B (0%)
build/nux/index.js 3.4 kB +2 B (0%)
build/plugins/index.js 2.56 kB +1 B
build/redux-routine/index.js 2.85 kB -2 B (0%)
build/rich-text/index.js 13.9 kB +1 B
build/server-side-render/index.js 2.77 kB -1 B
build/url/index.js 4.06 kB +1 B
build/viewport/index.js 1.85 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/api-fetch/index.js 3.41 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/style-rtl.css 7.59 kB 0 B
build/block-library/style.css 7.58 kB 0 B
build/block-library/theme-rtl.css 754 B 0 B
build/block-library/theme.css 754 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.25 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ntsekouras
Copy link
Contributor

I think this might cause some problems, since there isn't even a link like quick inserter to browse all and a user might want to search something that is not in top 6.

There had been some issues about limiting to 6 in quick inserter as well in the past..

@mcsf
Copy link
Contributor

I pushed 0cc4970, needed to slice the list if one of the SHOWN_BLOCK_TYPES includes block variations. For example, if core/embed is among the six most "frecent" blocks, typing / will show a list containing dozens of results.

ntsekouras
ntsekouras approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have my concerns about limiting to 6 results, as there had been some issues about limiting to 6 in quick inserter as well, but there the browse all button exists.

Code looks good though and we can alternatively revisit, if any new issues about this occur.

Good catch with the variations too 💯

@youknowriad
Copy link
Contributor Author

6 seems a bit low for the slash inserter indeed, let's make it 9 to start with.

mcsf
mcsf reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good with 9 🚢

@mcsf mcsf changed the title Limit the block slash inserter to 6 items and show most used by default Limit the block slash inserter to 9 items and show most used by default Sep 9, 2020
@youknowriad youknowriad merged commit 51e5a2c into master Sep 9, 2020
@youknowriad youknowriad deleted the update/block-autocompleter branch September 9, 2020 09:41
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 9, 2020
@mtias
Copy link
Member

Thanks!

This was referenced Mar 18, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf left review comments

@ntsekouras ntsekouras ntsekouras approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@mtias mtias Awaiting requested review from mtias

Assignees

@youknowriad youknowriad

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youknowriad @ntsekouras @mcsf @mtias