Refactor and make consistent post and site headers. #25134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasmussen added [Type] Enhancement 
Size Change: +125 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
youknowriad added [Feature] Full Site Editing and removed [Type] Code Quality 
The only thing I noticed was that the site editor on mobile got pretty funky:
On master, it overflows (also bad): Perhaps this would be best resolved in a separate issue? |
Thanks so much for looking. I think that's definitely an issue to solve, but it was secondary to this PR. I think it's perhaps best as a separate PR because some aspects of that top heading are still very much in flux, and so it may be better to update the mobile version once that settles a bit. What do you think? |
That makes sense to me. |
This was referenced
Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR refactors button margins in the top toolbar, and copies them to the site editor to make it consistent.
Site and post headers after this PR:
Site header before: