New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom spacing support using theme.json #25141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
youknowriad added Customization
Issues related to Phase 2: Customization efforts
[Type] Experimental
Experimental feature or API.
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Sep 8, 2020
youknowriad requested review from ellatrix, spacedmonkey and TimothyBJacobs as code owners
September 8, 2020 08:58
11 tasks
$features['global']['spacing'] = array(); | ||
} | ||
$features['global']['spacing']['custom'] = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically not needed since it's experimental and we're not obliged to ensure backward compatibility here but it's harmless so we can keep both experimental APIs for the moment. We can remove it once theme.json is stable if needed.
Size Change: +185 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization
Issues related to Phase 2: Customization efforts
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related #20588
Similar to #24761 but for custom padding.
The idea of this PR is to support disabling/enabling custom spacing support from theme.json.
Testing instructions
spacing.custom
path.