Data: remove flowRight call from metadata reducer #25180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `flowRight` call is useful only when it flows over two or more functions. But since the refactoring that gave each store its own metadata and the `core/data` store became just proxy to all of them, there is no `onSubKey( 'reducerKey' )` and the `flowRight` with one arg is an identity.
jsnajdr added [Type] Code Quality 
Size Change: -3 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
flowRightcall is useful only when it flows over two or more functions. But since the refactoring that gave each store its own metadata and thecore/datastore became just proxy to all of them, there is noonSubKey( 'reducerKey' )and theflowRightworked with just one function.