New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safeguard to AuthorSelect component until authors are fetched #25214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ntsekouras added [Type] Bug
An existing feature does not function as intended
[Priority] High
Used to indicate top priority items that need quick attention
labels
Sep 10, 2020
ntsekouras requested review from ajitbohra and chrisvanpatten as code owners
September 10, 2020 08:58
Size Change: +4 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High
Used to indicate top priority items that need quick attention
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
In some cases the author list in
AuthorSelect
do not have enough time to load and that leads to fail with error.This is just a safeguard to render only if a list of authors is provided.
How has this been tested?
I don't know what changed, but you can test it by creating a
Query
block in master. Some times it renders and some times fails.