Fix stylesheet generation #25293
Fix stylesheet generation #25293
Conversation
oandregal requested review from spacedmonkey and TimothyBJacobs as code owners
oandregal added [Type] Bug 
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
I read that and I agree that we'd want to have a more general method. However, I'm a little worried about the performance costs of using a regexp in such a hot path to convert camel to kebab case. I'm a little torn about this, to be honest, and feel some urgency to have a path that can go in Gutenberg 9.0. Would it work for you if we merge this PR as a hotfix and then keep talking about a general approach in yours? This way we already have a fix and don't need to rush #25250 |
Meh sorry about the double-approval... must have clicked the approve button twice.
Agreed, I sat on this one for hours before submitting the other PR. |
| * @return string CSS property name. | ||
| */ | ||
| function gutenberg_experimental_global_styles_get_css_property( $style_property ) { | ||
| switch ( $style_property ) { |
There was a problem hiding this comment.
I guess instead of having a switch we may have an array with the mappings:
array(
'backgroundColor' => ''background-color',
'fontSize' => 'font-size',
...
)
* Fix stylesheet generation * Make linter happy
In #25185 we centralized and modified the support keys to use camelCase instead of kebab-case. By doing so, we introduced a bug by which the stylesheet generation won't be able to determine which properties to output and will only include
colorandbackground. This PR fixes it.How to test
global-styles-inline-cssinline stylesheet. Verify the CSS propscolor,font-size,line-height,background-color, and--wp--style--color--linkare present. Previously, onlycolorandbackgroundcould be present.