New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update columns index.js adding translatable (i18n) parts #18162
Conversation
Adding translatable (i18n) parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nukaga thank you for your contribution 👍
These strings are example text and not supposed to be readable, but I guess in some languages with different charsets this example text may not look good, so making them translatable seems like a solution. Any thoughts on this @swissspidy?
Just think about Arabic or Japanese and how lorem ipsum does not work for these languages. |
Ideally we'd also add some translator comment that mentions that this is example text. |
Should use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi @torounit, _x should be used when the same word/string can have different translations depending on the context it is used. It seems this example strings don't fit that use case, so I think we can use __. |
Adding translatable (i18n) parts
Description
Part of the series of sentences displayed in "lorem ipsum" was not translatable.
Types of changes
Bug fix (non-breaking change which fixes an issue)