Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Support reduced-motion for Social Links transitions #18750

Merged
merged 2 commits into from Dec 9, 2019
Merged

Support reduced-motion for Social Links transitions #18750

merged 2 commits into from Dec 9, 2019

Conversation

richtabor
Copy link
Member

Description

This PR closes #18749 by adding the reduce-motion mixin to the social links, adhering to the Ally considerations from the Animations doc.

How has this been tested?

Tested via supported browsers.

Screenshots

Edit:
ScreenFlow

Save:
ScreenFlow-save

Types of changes

This PR only affects SCSS files, enhancing support for the reduced-motion OS-level setting.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Nov 26, 2019
@richtabor richtabor requested a review from mkaz as a code owner November 26, 2019 12:32
@richtabor richtabor self-assigned this Nov 26, 2019
mkaz
mkaz approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine. 👍

@mkaz mkaz merged commit b40bf6f into master Dec 9, 2019
@mkaz mkaz deleted the fix/18749/social-links-reduce-motion branch December 9, 2019 17:47
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

Assignees

@richtabor richtabor

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.

Implement reduce-motion mixin for Social Links hover scale
3 participants
@richtabor @mkaz @youknowriad