Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import WritingFlow and ObserveTyping #19005

Merged
merged 1 commit into from Dec 9, 2019
Merged

fix: Import WritingFlow and ObserveTyping #19005

merged 1 commit into from Dec 9, 2019

Conversation

WebPraktikos
Copy link
Contributor

Description

Inside the block-editor “Usage” readme instructions, modules WritingFlow and ObserveTyping are used but not imported

Types of changes

Bug fix (non-breaking change which fixes an issue)

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement! While you're making these changes, could you also include the necessary import for Popover ? It should be imported from @wordpress/components.

@WebPraktikos
Copy link
Contributor Author

Oh, we keep missing it :D Now it includes Popover.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit 6eb2029 into WordPress:master Dec 9, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants