New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Add readme for CustomSelectControl
. #19026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
epiqueras added [Type] Developer Documentation
Documentation for developers
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
labels
Dec 9, 2019
epiqueras requested review from ajitbohra, chrisvanpatten, jorgefilipecosta, talldan and youknowriad as code owners
December 9, 2019 22:07
5 tasks
@epiqueras #15639 ← have been swamped with work for a bit, but basically this PR needs to be finished. will see if I can rebase this week and get it done, unless you want to take it across the finish line |
Thanks for the clarification. I’m not familiar with how the docs work and I have to get back to full site editing work, but I don’t think this is blocking anything, so no rush.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme.md looks good 👍
We can address the manifest-devhub issue in the #15639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Developer Documentation
Documentation for developers
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why do we have a
docs/manifest-devhub.json
and an incompletedocs/manifest.json
?