Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add readme for CustomSelectControl. #19026

Merged
merged 1 commit into from Dec 29, 2019

Conversation

epiqueras
Copy link
Contributor

Why do we have a docs/manifest-devhub.json and an incomplete docs/manifest.json?

@epiqueras epiqueras added [Type] Developer Documentation Documentation for developers [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components labels Dec 9, 2019
@epiqueras epiqueras added this to the Future milestone Dec 9, 2019
@epiqueras epiqueras self-assigned this Dec 9, 2019
@chrisvanpatten
Copy link
Member

@epiqueras #15639 ← have been swamped with work for a bit, but basically this PR needs to be finished. will see if I can rebase this week and get it done, unless you want to take it across the finish line

@epiqueras
Copy link
Contributor Author

epiqueras commented Dec 10, 2019 via email

@karmatosed karmatosed added this to Design feedback in Tightening Up Dec 11, 2019
@karmatosed karmatosed moved this from Design feedback to In Progress in Tightening Up Dec 11, 2019
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme.md looks good 👍
We can address the manifest-devhub issue in the #15639

@mkaz mkaz merged commit 8084e23 into master Dec 29, 2019
@mkaz mkaz deleted the add/custom-select-control-readme branch December 29, 2019 17:49
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.2 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
No open projects
Tightening Up
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants