Fix: Drag & Drop does not work on the widgets screen #19029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jorgefilipecosta added [Type] Bug jorgefilipecosta deleted the fix/drag-drop-does-not-work-on-the-widgets-screen branch
| @@ -21,25 +22,27 @@ function Layout( { blockEditorSettings } ) { | |||
| const [ selectedArea, setSelectedArea ] = useState( null ); | |||
| return ( | |||
| <SlotFillProvider> | |||
There was a problem hiding this comment.
This screen could reuse the EditorRegions component (if we find a way to expose it properly) and avoid duplicate a lot of CSS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Currently, Drag & Drop does not work on the widgets screen. That happens not only because DropZoneProvider was not being. Adding DropZoneProvider does not immediately fix the problem and it was not easy to find the cause. I started debugging the Drag & Drop mechanism but the problem was not there. The problem was that the drop-zone appender took all the widgets to screen so when dragging & dropping a block the triggered area was not the blocks but the appender(which did nothing). This PR fixes that problem with a simple CSS rule that does not changes the visual.
How has this been tested?
I verified I could use drag & drop on the widgets screen.