Block Editor: Remove block inserter shortcuts #19045
Conversation
aduth added [Feature] Inserter aduth requested review from ellatrix, talldan and youknowriad as code owners
I've considered this as well for some time now. I agree that they don't bring much value. Any perspective here @ZebulanStanphill @jasmussen @mapk |
Remove them! I've not used them once. |
Goodbye inserter shortcuts, you will not be missed 👋 |
Yes please! |
I never use the inserter shortcut buttons. The slash inserter is faster and more useful. I'd go a step further and change the empty Paragraph inserter to look the same as it does for nested blocks, since having the icon to the left and outside of the block border is kind of confusing. |
+1 to remove :) |
Do you think this would be fine for a follow-up pull request, or is the need for this directly impacted by the removal of the shortcuts? Given the likelihood that discussions surrounding #10519 can stagnate, I'm inclined to push for more incremental steps. I sense what you're suggesting is similar to what was explored in #11329, which was closed in part due to lingering questions around (intentional?) differences between top-level and nested block inserters (#11329 (comment)). |
I've also found they cause confusion for users who hover over them wondering what they are and if they're what they need. I'm for removing them. |
@aduth I'm fine with just removing the block inserter shortcuts for now. However, I do think that with them gone, there is little reason to have the inserter look different at the top level vs. nested contexts. |
Do it! |
aduth force-pushed the remove/block-appender-shortcuts branch from 9ff70d4 to 7f5ff74 Compare
Related: #10519, #4951
Partially addresses #5055
This pull request seeks to remove the block inserter "shortcuts" which would previously appear when hovering the "appender" area below the list of blocks in the block editor.
Needs Design/Accessibility Feedback: It is proposed that they be removed due to:
Their removal yields a simplification, both in the technical implementation and to the benefit of users in reducing the surface area of block insertion options.
Testing Instructions:
Verify there are no regressions in the insertion of blocks, specifically in using the "default" appender, which is expected to show either when:
(It's acknowledged that the above logic flow is still prone to confusion, which could be addressed in subsequent improvements surrounding #10519)
The "+" button should still be shown where the "shortcuts" would have previously been expected to appear, to the left of the block list.