Fix: useColors crashes on storybook #19046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jorgefilipecosta requested review from ellatrix, talldan and youknowriad as code owners
jorgefilipecosta added [a11y] Color Contrast [Type] Bug 
jorgefilipecosta added a commit that referenced this pull request
Dec 11, 2019
6 tasks
1 task
1 task
priethor added [Focus] Accessibility (a11y) Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
We were verifying if a parent node exists to use a background color, but we were not verifying the node type and getComputedStyle can not be used with some node types (e.g: document).
Currently adding paragraphs or headings on the storybook playground is impossible, this PR fixes the issue by adding a simple check.
How has this been tested?
I executed npm run storybook:dev.
I opened the playground and verified I could add paragraphs and headings.