Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Developer Tools setup in Getting Started #19074

Merged
merged 4 commits into from Dec 20, 2019
Merged

Conversation

mkaz
Copy link
Member

Description

Adds a new section for Developer Tools for setting up an editor to the Getting Started page in the Contributors Handbook. The section recommends setting up EditorConfig and Prettier extensions.

This can precede the Prettier PR #18048 to help people get setup prior, wording will just need to be updated after that release to remove references to the PR in the doc.

How has this been tested?

Follow directions on documentation page, found on branch here

Types of changes

Developer docs.

@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Dec 11, 2019
Copy link

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for ensuring the prettier work is reflected in the docs!

docs/contributors/getting-started.md Outdated Show resolved Hide resolved
@ntwb
Copy link
Member

ntwb commented Dec 14, 2019

@mkaz, I just added a comment on #18408,

#18048 (comment)

I suspect this will not be an issue, so long as the user does not have a Prettier extension where they have configured the extension settings... I'm wondering if the extension settings would override any settings in the .preetierrc file 🤔

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@mkaz mkaz merged commit 334b0b2 into master Dec 20, 2019
@mkaz mkaz deleted the add/doc-prettier branch December 20, 2019 00:33
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants