Blob: Add types #19092
Blob: Add types #19092
Conversation
sirreal added [Type] Code Quality | @@ -3,6 +3,9 @@ | |||
| */ | |||
| const { createObjectURL, revokeObjectURL } = window.URL; | |||
| /** | |||
| * @type {{[key: string]: File|undefined}} | |||
There was a problem hiding this comment.
Initially, my editor ignored the | undefined part of this type and the following one. Adding explicit strictNullChecks to the tsconfig restored it.
| @@ -27,7 +30,7 @@ export function createBlobURL( file ) { | |||
| * | |||
| * @param {string} url The blob URL. | |||
| * | |||
| * @return {?File} The file for the blob URL. | |||
| * @return {File|undefined} The file for the blob URL. | |||
There was a problem hiding this comment.
{?File} is a nullable type in JSDoc, equivalent to File | null, which isn't accurate.
There was a problem hiding this comment.
{?File}is a nullable type in JSDoc, equivalent toFile | null, which isn't accurate.
Yeah, I think you'll find a lot of examples like this in the codebase, where nullable type is used incorrectly as interchangeable with "optional" or "possibly undefined".
| @@ -12,6 +12,7 @@ | |||
| /* Strict Type-Checking Options */ | |||
| "strict": true, /* Enable all strict type-checking options. */ | |||
| "strictNullChecks": true, | |||
There was a problem hiding this comment.
This should be enabled via strict, but I some Type | undefined types didn't seem to be handled correctly. Adding this seems to fix the issue.
I wonder if strict + noImplicitAny results in odd behavior.
sirreal force-pushed the add/types-blob branch from fefa371 to 9d8ae89 Compare
Description
Part of #18838
Extracted from #18942
Add types to
blobpackage.Testing Instructions:
Verify type checking passes: