Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Remove unused blocks-font-size classname #19208

Merged
merged 1 commit into from Dec 20, 2019
Merged

Remove unused blocks-font-size classname #19208

merged 1 commit into from Dec 20, 2019

Conversation

talldan
Copy link
Contributor

Description

This is a very tiny PR that removes a classname blocks-font-sizes from the paragraph block's Text Settings panel.

The css for this classname seem to have been removed a while ago from the paragraph block, so removing it has no visual effect. The only usage was in an end-to-end test where it was used as part of a selector, but this was easily replaced with the font-size-picker classname.

How has this been tested?

  1. Add a paragraph block
  2. Try changing the font size
  3. Observe that the font size picker looks the same as it did previously

Types of changes

Non-breaking task

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@talldan talldan added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Dec 18, 2019
@talldan talldan self-assigned this Dec 18, 2019
@talldan talldan mentioned this pull request Dec 18, 2019
Merged
6 tasks
draganescu
draganescu approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this. Initially I found the "default" setting to be missing but after a rebase everything was OK. All good codewise.

@draganescu draganescu merged commit 58fcf4d into master Dec 20, 2019
@draganescu draganescu deleted the remove/unused-classname branch December 20, 2019 14:26
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@dougwollison dougwollison mentioned this pull request Jan 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@Soean Soean Awaiting requested review from Soean

Assignees

@talldan talldan

Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talldan @draganescu @youknowriad