Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Guide Accessibility: Change the aria-current expression to be a step instead of a boolean #19290

Merged
merged 2 commits into from Dec 21, 2019
Merged

Guide Accessibility: Change the aria-current expression to be a step instead of a boolean #19290

merged 2 commits into from Dec 21, 2019

Conversation

MarcoZehe
Copy link
Contributor

@MarcoZehe MarcoZehe commented Dec 21, 2019 •
edited

Description

Change the attribute value that is set for aria-current to be "step", not "true" or "false".

This is in accordance with the documentation of aria-current:

A step token used to indicate a link within a step indicator for a step-based process, where the link is visually styled to represent the current step.

How has this been tested?

Tested in StoryBook using NVDA and Firefox.

Screenshots

Types of changes

Enhancement.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@MarcoZehe MarcoZehe mentioned this pull request Dec 21, 2019
Merged
6 tasks
@ellatrix
Copy link
Member

Perhaps a link to the specification could be left as a comment above?

@MarcoZehe
Copy link
Contributor Author

Perhaps a link to the specification could be left as a comment above?

Done, I updated the description.

@ellatrix
Copy link
Member

@MarcoZehe Ah, I meant in the above the code adding aria-current. 😄 It might be nice as many developer are not very aware of what (some) aria- attributes do.

ellatrix
ellatrix approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! ❤️

@MarcoZehe MarcoZehe merged commit 061dfb0 into master Dec 21, 2019
@MarcoZehe MarcoZehe deleted the fix/UseAriaCurrentStep branch December 21, 2019 20:06
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcoZehe @ellatrix @youknowriad