Block Directory: Update the regular expression that determines whether the plugin is using an img URL or an icon slug. #19316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…r the plugin is using an img or an icon. Fixes: WordPress#19264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The block directory API returns either an icon slug or a URL for the plugin's icon. This PR changes the regular expression to allow for an optional query string after the image URL. A detailed explanation of the issue can be found here: #19264 .
Fixes: #19264
How has this been tested?
Unit tests have been added to test this change.
Currently testing 3 cases:
icon: https://ps.w.org/listicles/assets/icon-128x128.png✅icon: https://ps.w.org/listicles/assets/icon-128x128.png?rev=2011672&test=234234✅icon: block-default✅Types of changes
This is a bug fix. The current regular expression does not account for a query string being added by the CDN serving the plugins and its assets. Read more here: #19264
Checklist: