New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor edit post shortcuts to use the keyboard-shortcuts package #19320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
youknowriad added [Type] Code Quality
Issues or PRs that relate to code quality
[a11y] Keyboard & Focus labels
Dec 24, 2019
youknowriad force-pushed the update/edit-post-shortcuts branch from
December 24, 2019 10:28
e8b8841
to ed437ef
Compare
youknowriad requested review from ajitbohra, chrisvanpatten and mkaz as code owners
December 24, 2019 10:28
youknowriad force-pushed the update/edit-post-shortcuts branch from
December 25, 2019 07:09
ed437ef
to 4abf7c6
Compare
youknowriad force-pushed the update/edit-post-shortcuts branch from
December 25, 2019 07:12
4abf7c6
to c47f1f4
Compare
Comment on lines +43 to +47
const formattingMethods = { | ||
display: displayShortcut, | ||
raw: rawShortcut, | ||
ariaLabel: shortcutAriaLabel, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doubt it has much overhead, and I could grant an argument that it benefits from colocation, but this appears to be constant, could be defined at the top of the file.
priethor added the [Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've also refactored the components that I touched to use useSelect/useDispatch.
I've noticed that the "sidebar toggle" shortcut is not working but that's on master too.