New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor navigateRegions HoC to rely on the shortcuts package. #19327
Merged
youknowriad merged 5 commits into master from update/refactor-navigate-regious-shortcuts
Dec 26, 2019
Merged
Refactor navigateRegions HoC to rely on the shortcuts package. #19327
youknowriad merged 5 commits into master from update/refactor-navigate-regious-shortcuts
Dec 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
youknowriad requested review from ajitbohra, chrisvanpatten, jorgefilipecosta, mkaz and talldan as code owners
December 25, 2019 10:10
youknowriad force-pushed the update/refactor-navigate-regious-shortcuts branch from
December 25, 2019 11:36
e6d223e
to f7cde6a
Compare
youknowriad force-pushed the update/refactor-navigate-regious-shortcuts branch from
December 25, 2019 11:38
f7cde6a
to 0e69767
Compare
youknowriad added [a11y] Keyboard & Focus [Type] Code Quality
Issues or PRs that relate to code quality
labels
Dec 25, 2019
priethor added the [Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
blocked by #19325
This also shows the aliases of a shortcut in the keyboard shortcuts modal.