Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor navigateRegions HoC to rely on the shortcuts package. #19327

Merged
merged 5 commits into from Dec 26, 2019

Conversation

youknowriad
Copy link
Contributor

blocked by #19325

This also shows the aliases of a shortcut in the keyboard shortcuts modal.

@youknowriad youknowriad force-pushed the update/refactor-navigate-regious-shortcuts branch from e6d223e to f7cde6a Compare December 25, 2019 11:36
@youknowriad youknowriad force-pushed the update/refactor-navigate-regious-shortcuts branch from f7cde6a to 0e69767 Compare December 25, 2019 11:38
@youknowriad youknowriad added [a11y] Keyboard & Focus [Type] Code Quality Issues or PRs that relate to code quality labels Dec 25, 2019
@youknowriad youknowriad merged commit 950b133 into master Dec 26, 2019
@youknowriad youknowriad deleted the update/refactor-navigate-regious-shortcuts branch December 26, 2019 08:34
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants