Fix the multiple list block shortcuts #19334
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed two things:
This PR wraps those shortcuts in an
isSelected
check to fix that.That said, I also took a look at the RichtextShortcut component and after some thinking I concluded that this component is useless and also misleading.
ifBlockEditSelected
like block controls... but that's not a good approach because conceptually speaking, you can have a RichText outside a block or multiple RichText in the same block, so this won't solve anything really.KeyboardShortcuts
component.