fix missing button-block-appender icon on Firefox 71 and Safari 13 #19366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bartczyz requested review from ellatrix, talldan and youknowriad as code owners
| outline: $border-width dashed $dark-gray-150; | ||
| width: 100%; | ||
| height: 100%; |
There was a problem hiding this comment.
I'm not sure about this rule as it's dependent on the parent element and this is a generic component, should this be auto instead of100%?
There was a problem hiding this comment.
Yes, I agree! :)
I actually realised this after I opened the PR, but forgot to commit the update.
youknowriad added the [Type] Bug Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19246
How has this been tested?
Manual testing using:
Screenshots
Before:
After:
Types of changes
Small style updates.
Checklist: