New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused is-hovered class #19390
Conversation
@@ -534,14 +472,9 @@ function BlockListBlock( { | |||
<IgnoreNestedEvents | |||
id={ blockElementId } | |||
ref={ wrapper } | |||
onMouseOver={ maybeHover } | |||
onMouseOverHandled={ hideHoverEffects } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was the only usage of the "Handled" behavior for IgnoreNestedEvents
, so it could be removed. Not sure that it will make a ton of difference, but at least simplifying a bit.
Effectively would amount to a revert of 0d0c8e0d55849529227df3540ad35ff3edf5be5b (from #5658)
I think this is a sensible change. If you create a new (empty) paragraph, it is selected, and you'll see the side inserter. If you select another block, the side inserter is gone. It makes sense to select the block again to see the side inserter. Additionally, there's the in-between inserters which are consistently available for every block on hover. |
Description
This PR removed the
is-hovered
class on blocks when hovering over them. The styles had been removed in #18862.It also removes the hover state in the block, which is only used for one thing: showing the side block inserter when the default block is empty. I would suggest to either:
I chose the first option, but I don't mind changing it.
-- @jasmussen
It's also worth noting that this removes a number of event handlers that are added to every single block.
Also reverts 0d0c8e0 (from #5658) because this is no longer needed.
How has this been tested?
Screenshots
Types of changes
Checklist: