Page MenuHomePhabricator
Create Task
Maniphest T245929

QualityOversight: Still show form when no actions match
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/w/index.php?title=Special%3AAdvancedReviewLog&namespace=0&user=&status=3&automatic=1 - there is no automatic unacceptance, so the search turns up blank, but the form (eg as seen at https://en.wikipedia.org/w/index.php?title=Special%3AAdvancedReviewLog&namespace=0&user=&status=-1&automatic=0) should still be shown

Details

Subject Repo Branch Lines +/-
QualityOversight: Even if the parameters are invalid, show the form mediawiki/extensions/FlaggedRevs master +1 -0
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Feb 22 2020, 10:01 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 22 2020, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 renamed this task from AdvancedReviewLog: Still show form when no actions match to QualityOversight: Still show form when no actions match.Feb 22 2020, 10:07 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 added a project: Patch-For-Review.
gerritbot added a comment.Feb 22 2020, 10:08 PM

Change 574199 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] QualityOversight: Even if the parameters are invalid, show the form

https://gerrit.wikimedia.org/r/574199
DannyS712 mentioned this in T185664: Code stewardship review: FlaggedRevs.Feb 22 2020, 10:15 PM
gerritbot added a comment.Feb 24 2020, 11:03 PM

Change 574199 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] QualityOversight: Even if the parameters are invalid, show the form

https://gerrit.wikimedia.org/r/574199
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 25 2020, 12:03 AM
DannyS712 closed this task as Resolved.Feb 25 2020, 6:19 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Mar 4 2020, 7:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL