Search: Fix attribute defaults #23777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
noisysocks added [Type] Bug 
@ellatrix: This should go in 5.5 Beta 2. |
Size Change: +4 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Prior to d26842b, the Search block's label and buttonText attributes defaulted to `__( 'Search' )`. This meant that adding a Search block to a post or page resulted in `<!-- wp:search /-->` being inserted into the HTML. In d26842b, the defaults were removed so that Search could use a block.json file. The default values were instead implemented using a default block variation. This, however, meant that Search blocks added prior to d26842b would render with a blank label and button. This fix is to default label and buttonText to `__( 'Search' )` in the render_callback. Care must be taken here to permit these attributes to be '' in which case the label and/or button are hidden.
noisysocks force-pushed the fix/default-search-attributes branch from ab0133f to 9f451a1 Compare
I did wonder this. We could remove the variation but then would have to change the frontend to display |
youknowriad pushed a commit that referenced this pull request
Jul 13, 2020
* Search: Fix attribute defaults Prior to d26842b, the Search block's label and buttonText attributes defaulted to `__( 'Search' )`. This meant that adding a Search block to a post or page resulted in `<!-- wp:search /-->` being inserted into the HTML. In d26842b, the defaults were removed so that Search could use a block.json file. The default values were instead implemented using a default block variation. This, however, meant that Search blocks added prior to d26842b would render with a blank label and button. This fix is to default label and buttonText to `__( 'Search' )` in the render_callback. Care must be taken here to permit these attributes to be '' in which case the label and/or button are hidden. * Try to trick GitHub into re-running tests
youknowriad removed the Backport to WP Beta/RC Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes https://core.trac.wordpress.org/ticket/50608.
Prior to #22422, the Search block's
labelandbuttonTextattributes defaulted to__( 'Search' ). This meant that adding a Search block to a post or page resulted in<!-- wp:search /-->being inserted into the HTML.In #22422, the defaults were removed so that Search could use a
block.jsonfile. The default values were instead implemented using a default block variation.This, however, meant that Search blocks added prior to #22422 would render with a blank label and button. This is the bug outlined in the ticket above.
This fix is to default label and buttonText to
__( 'Search' )in the block'srender_callback. Note that care must be taken here to permit these attributes to be''which hides the label and/or button.To test:
<!-- wp:search /-->into a post's markup.