[Wayland] Implement async clipboard
Categories
(Core :: Widget: Gtk, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We may provide alternative clipboard (async) for Wayland code to text/fix various clipboard issues we have on Wayland now.
|
Assignee |
|
Comment 1•
3 years ago
|
||
When widget.wayland.async-clipboard.enabled use async clipboard and D&D handlers provided by Gtk.
|
|
Assignee |
|
Comment 2•
3 years ago
|
||
I use this command for local testing:
MOZ_ENABLE_WAYLAND=1 ./mach mochitest dom/base/test/test_copypaste.html --setpref widget.wayland.test-workarounds.enabled=true --setpref widget.wayland.async-clipboard.enabled=true --enable-webrender
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/ca7dd68c51a2 [Wayland] Implement async clipboard, r=rmader
|
|
|
Comment 4•
3 years ago
|
||
| bugherder | ||
|
|
Assignee |
|
Comment 5•
3 years ago
•
|
||
To enable the async clipboard support, please go to about:config, set widget.wayland.async-clipboard.enabled to true and restart browser.
|
|
|
Comment 6•
3 years ago
|
||
It works perfectly now, both with and without the option enabled.
Thank you all !
|
|
|
Comment 7•
3 years ago
|
||
On my system (GNOME Wayland / Arch Linux) there's a visible delay (~500 ms?) between pasting and the new text being displayed, which is quite annoying when you're pasting into the address bar.
|
|
|
|
Comment 8•
3 years ago
|
||
(In reply to mcnuggetsrooster from comment #6)
It works perfectly now, both with and without the option enabled.
Thank you all !
Sorry, bad thread...
#1722197
|
|
Assignee |
|
Comment 9•
3 years ago
|
||
(In reply to Laurențiu Nicola from comment #7)
On my system (GNOME Wayland / Arch Linux) there's a visible delay (~500 ms?) between pasting and the new text being displayed, which is quite annoying when you're pasting into the address bar.
Can you open a new bug for it and attach clipboard log of that? (run with MOZ_LOG="WidgetClipboard:5" env variable).
Thanks.
|
|
Assignee |
|
Updated•
3 years ago
|
|
|
|
|
Comment 10•
3 years ago
|
||
I will, but I'd rather wait for bug 1727268, just in case it's caused by blocking on that mutex.
I have another question: I'm seeing relatively many clipboard-related crashes, some with different stack traces. crash-stats.mozilla.org doesn't have a bug associated with them. Should I do anything about this, maybe click "File a bug" on c-s.m.o?
|
|
|
|
Comment 11•
3 years ago
|
||
Can you open a new bug for it and attach clipboard log of that?
Already did, bug 1726360.
|
|
Assignee |
|
Updated•
3 years ago
|
|
|
Assignee |
|
Comment 12•
3 years ago
|
||
(In reply to Laurențiu Nicola from comment #10)
I will, but I'd rather wait for bug 1727268, just in case it's caused by blocking on that mutex.
I have another question: I'm seeing relatively many clipboard-related crashes, some with different stack traces. crash-stats.mozilla.org doesn't have a bug associated with them. Should I do anything about this, maybe click "File a bug" on c-s.m.o?
Feel free to file them, I can look at it.
|
|
|
Comment 13•
3 years ago
|
||
I've just downloaded and installed FF93 from the Fedora 34 repository. Alas, this problem is not fixed. Can we take a look at this again?
|
|
Assignee |
|
Comment 14•
3 years ago
|
||
Async clipboard was implemented in 93 but it's enabled by default at 94. In 93 you need to go to about:config and set widget.wayland.async-clipboard.enabled to true and restart browser.
|
|
|
|
Comment 15•
3 years ago
|
||
Confirmed. Works like a charm. Thanks for all the hard work. I appreciate it very much.
|
|
|
Comment 16•
3 years ago
|
||
Setting widget.wayland.async-clipboard.enabled to true also seems to have fixed a problem I had (on Fedora 34) where I could copy from other applications and paste to Firefox, but not copy in FIrefox and paste to other applications. Thank you.
Description
•