[x11/xwayland] I can't get the right click menu on the PiP window anymore
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
Tracking | Status | |
---|---|---|
relnote-firefox | --- | 101+ |
firefox-esr91 | --- | unaffected |
firefox101 | --- | verified |
firefox102 | --- | verified |
firefox103 | --- | verified |
People
(Reporter: julienw, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes, text/x-phabricator-request
|
pascalc
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
|
Details | Review |
Hey,
I'm a big fan of the PiP feature. Being on Linux I use several virtual desktops, and I was using the right click menu to toggle the option "Always on visible workspace" so that it's always visible even when I switch the workspace.
Unfortunately the right click menu doesn't work anymore for some time so I can't do it anymore, and this is a huge issue for me.
I'm using Gnome 3.38 on latest Debian Stable, with the xwayland backend.
Thanks
|
Reporter |
|
Comment 1•
2 years ago
|
||
After mozregression, I get this pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1eb6fe5a1fa5457425c5a33f212516a5eeaa381&tochange=498e0e6f9b19107c8c17525a3d01a659f89002e8
It looks like Bug 1756903 is the culprit :)
Hey Emilio, any thoughts about that?
Maybe it could make sense that the option Always on visible workspace
is toggled by default for this window too, but I'm not sure.
|
Reporter |
|
Updated•
2 years ago
|
|
Reporter |
|
Updated•
2 years ago
|
|
Assignee |
|
Updated•
2 years ago
|
|
Assignee |
|
Comment 2•
2 years ago
|
||
This works in both X11 and Wayland, with system and client decorations.
Also don't dynamically load it, we require gtk 3.14 so we know it's
available.
|
|
|
Updated•
2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a746e4adc673 Use top-level gdk window to show PiP menu. r=stransky
|
|
|
Comment 4•
2 years ago
|
||
bugherder |
|
Assignee |
|
Comment 5•
2 years ago
|
||
Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky
Beta/Release Uplift Approval Request
- User impact if declined: One liner fix for context menus on PiP windows.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple one liner
- String changes made/needed: no
- Is Android affected?: No
|
Assignee |
|
Updated•
2 years ago
|
|
|
|
Updated•
2 years ago
|
|
|
|
Comment 6•
2 years ago
|
||
Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky
Approved for 102 beta 3, thanks.
|
|
|
Comment 7•
2 years ago
|
||
bugherder uplift |
|
Reporter |
|
Comment 8•
2 years ago
|
||
Thanks, this works well now!
|
|
|
Comment 9•
2 years ago
•
|
||
Reproduced this issue on an affected Nightly build from 2022-05-31, on Ubuntu 20.04 (x11).
Verified fixed on latest Nightly 103.0a1 (20220602093647) and Firefox 102.0b3 (20220602074217 - treeherder build) on Ubuntu 20.04 and Ubuntu 21.04(wayland).
|
|
|
Comment 10•
2 years ago
|
||
Is this something we'd want to consider taking in a dot release also? Please nominate if so.
|
Assignee |
|
Comment 12•
2 years ago
|
||
Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky
Beta/Release Uplift Approval Request
- User impact if declined: see above
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: see above
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): One-liner.
- String changes made/needed: none
- Is Android affected?: No
|
|
|
Comment 13•
2 years ago
|
||
Comment on attachment 9278939 [details]
Bug 1771914 - Use top-level gdk window to show PiP menu. r=stransky
Approved for 101.0.1.
|
|
|
Comment 14•
2 years ago
|
||
bugherder uplift |
|
|
|
Comment 15•
2 years ago
|
||
Added to the 101.0.1 relnotes:
Fixed context menus not appearing when right-clicking Picture-in-Picture windows on some Linux systems
|
|
|
Comment 16•
2 years ago
|
||
Verified fixed on Firefox 101.0.1 (20220608170832) on Ubuntu 22.04 and Ubuntu 21.04.
|
|
|
Updated•
2 years ago
|
Description
•