Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=#mac-reviewers
ClosedPublic

Actions

Authored by m_kato on Jun 1 2022, 8:48 AM.

Details

Reviewers

spohl

Group Reviewers

mac-reviewers

Commits

rMOZILLACENTRALa2e465fa1db7: Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=mac…
rMOZILLACENTRAL6b7caf4b0c9b: Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=mac…
rMOZILLACENTRALfcab49b12871: Bug 1771823 - Don't clear system clipboard when exiting Firefox. r=mac…

Bugzilla Bug ID

1771823

Summary

This is regression by bug 666254. We shouldn't call
nsClipborad::EmptyClipboard() in destructor. Cached nsITransferable will
be cleared by nsBaseClipboard()'s destructor.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

m_kato created this revision.Jun 1 2022, 8:48 AM

Herald added a project: secure-revision. · View Herald TranscriptJun 1 2022, 8:48 AM

Harbormaster completed remote builds in B428661: Diff 585041.Jun 1 2022, 8:48 AM

phab-bot published this revision for review.Jun 1 2022, 8:48 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: emilio. · View Herald TranscriptJun 1 2022, 8:48 AM

spohl added a project: testing-exception-unchanged (Doesn't change behavior for users).Jun 1 2022, 10:57 AM

testing-exception-unchanged since it restores previous behavior. Not sure how difficult it would be to write a test that checks the system clipboard after Firefox is shut down, but this shouldn't hold up this regression fix.

This revision is now accepted and ready to land.Jun 1 2022, 11:00 AM