Page MenuHomePhabricator
Create Task
Maniphest T111894

MobileFrontend VisualEditor edit conflict detection does not work
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Noticed while testing code for T110272

Details

Subject Repo Branch Lines +/-
Don't try to redirect to Special:MobileEditor on a POST request mediawiki/extensions/MobileFrontend master +1 -1
Save dialog: Make review/resolve actions work in mobile mediawiki/extensions/VisualEditor master +18 -50
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.Sep 9 2015, 3:09 AM
Krenair raised the priority of this task from to High.
Krenair updated the task description. (Show Details)
Krenair added projects: MobileFrontend, Contributors-Team.
Krenair subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 3:09 AM
Krenair added a comment.Sep 9 2015, 4:05 AM

I tested this a few different times locally and on beta, with VE editing and source editing. And usually it half worked. :/
Krenair added a comment.Sep 10 2015, 10:40 PM
Observed MobileFrontend edit conflict behaviour localhost beta
Wikitext Error shown as text at bottom of screen Error shown as text at bottom of screen
VisualEditor API returns conflict, no UI error, stuck No error shown, overwrites?
Krenair renamed this task from MobileFrontend edit conflict detection does not work to MobileFrontend VisualEditor edit conflict detection does not work.Sep 10 2015, 10:41 PM
Krenair edited projects, added VisualEditor-MediaWiki; removed Contributors-Team.
Krenair set Security to None.
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 10 2015, 10:41 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Sep 11 2015, 11:14 PM
Jdforrester-WMF edited a custom field.
gerritbot subscribed.Sep 25 2015, 11:02 PM

Change 241249 had a related patch set uploaded (by Alex Monk):
Save dialog: Make review/resolve actions work in mobile

https://gerrit.wikimedia.org/r/241249
gerritbot added a project: Patch-For-Review.Sep 25 2015, 11:02 PM
Krenair claimed this task.Sep 25 2015, 11:04 PM
gerritbot added a comment.Sep 26 2015, 11:40 AM

Change 241250 merged by jenkins-bot:
Don't try to redirect to Special:MobileEditor on a POST request

https://gerrit.wikimedia.org/r/241250
Krenair mentioned this in rMEXT3c5103cd3f44: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 26 2015, 11:40 AM
Krenair mentioned this in rEMFR5a99e3b7f5bb: Don't try to redirect to Special:MobileEditor on a POST request.
gerritbot added a comment.Sep 26 2015, 11:42 AM

Change 241249 merged by jenkins-bot:
Save dialog: Make review/resolve actions work in mobile

https://gerrit.wikimedia.org/r/241249
Krenair mentioned this in rEVED3386f66770bc: Save dialog: Make review/resolve actions work in mobile.Sep 26 2015, 11:42 AM
Krenair added a comment.Sep 26 2015, 1:19 PM
Observed VisualEditor edit conflict behaviour localhost beta
Desktop No error returned, overwrites No error returned, overwrites
Mobile Errors correctly No error returned, overwrites
Krenair added a comment.Sep 26 2015, 1:33 PM

Turns out that's probably due to being the last user to edit the page logged in, causing the conflict to be suppressed by EditPage.
Jdforrester-WMF closed this task as Resolved.Sep 26 2015, 1:36 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:24 PM
Jdforrester-WMF removed a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL