Cursoring off of focused block nodes with shift behaves unexpectedly
Open, HighPublic8 Estimated Story Points

Actions

Assigned To

None

Authored By

	DLynch
	Mar 31 2016, 3:30 PM

Description

To reproduce:

create a document with this HTML: <p>Foo</p><figure class="ve-align-right"><img src="https://upload.wikimedia.org/wikipedia/commons/b/b3/Wikipedia-logo-v2-en.svg" width="100" height="50" alt="Example"><figcaption>caption</figcaption></figure><p>Bar</p>
Click the image to focus it.
Hold down the shift key and use the arrow keys to move the caret focus.

Expected result: The selection expands in the direction in which you moved the cursor.

Actual result: Depends on the direction moved. Left/up just moves the caret without expanding the selection. Right/down selects the interior of the focused node.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82	mediawiki/extensions/VisualEditor	master	+2 -1
	Fix cursoring off focused block nodes with shift	VisualEditor/VisualEditor	master	+59 -23

Customize query in gerrit

Related Objects

Mentioned In: T130389: ve.ce.LinearArrowKeyDownHandler.js is largely untested

Event Timeline

DLynch created this task.Mar 31 2016, 3:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2016, 3:30 PM

Change 280680 had a related patch set uploaded (by DLynch):
[Failing] Test cases for cursoring off focused block nodes with shift

https://gerrit.wikimedia.org/r/280680

gerritbot added a project: Patch-For-Review.Mar 31 2016, 3:30 PM

DLynch mentioned this in T130389: ve.ce.LinearArrowKeyDownHandler.js is largely untested.Mar 31 2016, 3:31 PM

Interestingly, shift+right off of the block node actually removes the blockImage+imageCaption from the data model, which I didn't really expect a call to setLinearSelection to be capable of.

Jdforrester-WMF triaged this task as High priority.Apr 1 2016, 10:11 AM

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.

In a brief test, this seems to work fine now…

(Nevermind, the unit tests still fail.)

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 23 2023, 12:43 AM

DLynch added a project: Editing-team (Kanban Board).Mar 28 2024, 4:53 PM

DLynch moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

DLynch added a project: Editing QA.

Change #280680 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix cursoring off focused block nodes with shift

https://gerrit.wikimedia.org/r/280680

Change #1025328 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

gerritbot added a project: Patch-For-Review.Mon, Apr 29, 11:34 AM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMon, Apr 29, 11:34 AM

Change #1025328 merged by jenkins-bot: