Page MenuHomePhabricator
Create Task
Maniphest T158445

VisualDiff: Handle table diffs separately
Open, MediumPublic
Actions

Description

Diffing tables as trees works in simple cases, but can fall apart in complex places (T149851, T158294) and times out regularly on long tables.

This library looks promising:
https://github.com/paulfitz/daff

Details

Subject Repo Branch Lines +/-
Daff table diffing VisualEditor/VisualEditor master +11 K -97
VWIP daff table diff VisualEditor/VisualEditor master +9 K -4
Customize query in gerrit

Related Objects
Search...

Status Subtype Assigned Task
Open None T211897 Visual Diffs: Improve table diffing
Open None T158445 VisualDiff: Handle table diffs separately
Resolved Tchanders T158294 Cell change missing in table diff

Event Timeline

Esanders created this task.Feb 17 2017, 7:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2017, 7:48 PM
Esanders added a parent task: T149851: Handle visual diffing of table cell merges.Feb 17 2017, 7:49 PM
Esanders added a parent task: T158294: Cell change missing in table diff.
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 19 2017, 8:46 PM
Esanders added a parent task: T158518: Removing and inserting table cells breaks diff.Feb 19 2017, 10:15 PM
Jdforrester-WMF triaged this task as Medium priority.Feb 27 2017, 7:18 PM
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 15 2017, 11:42 PM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 11:01 PM
Jdforrester-WMF changed the point value for this task from 8 to 40.Mar 6 2018, 2:23 PM
Jdforrester-WMF subscribed.Mar 6 2018, 2:26 PM

This clearly didn't block T143350 as we released without it.
Jdforrester-WMF removed a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 6 2018, 2:26 PM
Jdforrester-WMF removed a parent task: T158294: Cell change missing in table diff.
Jdforrester-WMF added a subtask: T158294: Cell change missing in table diff.
Jdforrester-WMF removed a parent task: T158518: Removing and inserting table cells breaks diff.Mar 6 2018, 2:28 PM
gerritbot subscribed.Aug 14 2018, 4:58 PM

Change 354520 had a related patch set uploaded (by Tchanders; owner: Esanders):
[VisualEditor/VisualEditor@master] VWIP daff table diff

https://gerrit.wikimedia.org/r/354520
gerritbot added a project: Patch-For-Review.Aug 14 2018, 4:58 PM
gerritbot added a comment.Aug 25 2018, 12:23 PM

Change 455321 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] VWIP daff table diff

https://gerrit.wikimedia.org/r/455321
gerritbot added a comment.Aug 25 2018, 12:24 PM

Change 354520 abandoned by Tchanders:
VWIP daff table diff

Reason:
Moved to Ifcfb44204d40ec2936058fc842dc8117b74637b1

https://gerrit.wikimedia.org/r/354520
• marcella moved this task from TR6: Visual diffs to Bug Fixes on the VisualEditor board.Nov 13 2018, 7:22 PM
• marcella added a parent task: T167508: Visual diff: Make VE visual diffs available for historical diffs via MediaWiki's DiffView page.Nov 13 2018, 7:37 PM
• marcella edited parent tasks, added: T211897: Visual Diffs: Improve table diffing; removed: T167508: Visual diff: Make VE visual diffs available for historical diffs via MediaWiki's DiffView page, T149851: Handle visual diffing of table cell merges.Dec 13 2018, 4:32 PM
• marcella removed the point value for this task.
• marcella moved this task from Bug Fixes to Freezer on the VisualEditor board.Dec 13 2018, 4:47 PM
gerritbot added a comment.Dec 21 2020, 4:18 PM

Change 455321 had a related patch set uploaded (by Esanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Daff table diffing

https://gerrit.wikimedia.org/r/455321
Esanders updated the task description. (Show Details)Dec 17 2021, 2:58 PM
Esanders updated the task description. (Show Details)Dec 18 2021, 3:47 PM
PatchDemoBot added a comment.Dec 18 2021, 3:51 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/0738399fff/w/
PatchDemoBot added a comment.Dec 18 2021, 5:12 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0738399fff/w/
Esanders updated the task description. (Show Details)Dec 18 2021, 11:39 PM
Esanders mentioned this in T269035: Image in table cell previewed at wrong aspect ratio after being swapped out.Jan 17 2022, 3:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL