Page MenuHomePhabricator
Create Task
Maniphest T173744

persistently addable/editable/removable Representations of a Form via the UI (M)
Closed, ResolvedPublic
Actions

Description

Right now the representation of a form is editable. However the edit is not persistently stored. The edit a user makes via the UI should be persistently stored and survive a page reload.

Acceptence Criteria:

  • User can add a representation in the UI and save it, reload the page and see the edited representation
  • We will create a new API-Module for this (sub-task)

Related Objects
Search...

Event Timeline

daniel created this task.Aug 21 2017, 4:18 PM
daniel added a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..
Lydia_Pintscher added a project: Wikidata-Former-Sprint-Board.Sep 5 2017, 2:03 PM
Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.
Lydia_Pintscher updated the task description. (Show Details)
• Aleksey_WMDE created subtask T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer.Sep 22 2017, 11:38 AM
• Aleksey_WMDE removed a subtask: T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer.Sep 22 2017, 11:43 AM
WMDE-leszek moved this task from Backlog to Proposed on the Wikidata-Former-Sprint-Board board.Oct 6 2017, 11:35 AM
WMDE-leszek moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.Oct 16 2017, 8:20 AM
Lydia_Pintscher renamed this task from [Story] Editable Representations of a Form (presistent) to [Story] Editable Representations of a Form (persistent).Oct 17 2017, 12:47 PM
daniel created subtask T178389: Create API for updating Form descriptions.Oct 17 2017, 1:36 PM
Lydia_Pintscher added a subscriber: thiemowmde.Oct 17 2017, 1:39 PM

Notes from estimation meeting today:

  • adding a representation of a form is already possible

Still needed:

  • API to edit a form (@daniel creates ticket) - @thiemowmde makes an overview with several options (generic vs. specialized API)
  • PM decision: should edits to several parts of the form be one or several edits and edit summaries?
daniel removed a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Oct 17 2017, 1:40 PM
Lydia_Pintscher added a comment.Oct 17 2017, 4:30 PM

Decision: If we have one edit button that people click then we also have one edit for the revision history. We do have one button so there will be one revision history entry.
Franziska_Heine renamed this task from [Story] Editable Representations of a Form (persistent) to [Story] Editable Representations of a Form (persistent) (M).Oct 24 2017, 1:15 PM
Franziska_Heine updated the task description. (Show Details)
Lydia_Pintscher moved this task from incoming to big tasks on the Wikidata Lexicographical data board.Oct 24 2017, 2:33 PM
Lydia_Pintscher renamed this task from [Story] Editable Representations of a Form (persistent) (M) to persistently editable Representations of a Form (M).Oct 24 2017, 3:16 PM
Lydia_Pintscher renamed this task from persistently editable Representations of a Form (M) to persistently editable Representations of a Form via the UI (M).Oct 24 2017, 3:35 PM
Lydia_Pintscher renamed this task from persistently editable Representations of a Form via the UI (M) to persistently addable/editable/removable Representations of a Form via the UI (M).Oct 24 2017, 3:42 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-11-22.Nov 21 2017, 3:00 PM
Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Nov 23 2017, 1:28 PM
Lydia_Pintscher mentioned this in T173742: persistently editable Grammatical Feature of a Form via the UI (M).Dec 4 2017, 6:43 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Jan 2 2018, 2:21 PM
Lucas_Werkmeister_WMDE subscribed.Jan 2 2018, 2:22 PM

(This might turn out to be S once we’re done with T173742: persistently editable Grammatical Feature of a Form via the UI (M).)
• Jonas added a comment.Jan 10 2018, 2:57 PM
In T173744#3691083, @Lydia_Pintscher wrote:

Decision: If we have one edit button that people click then we also have one edit for the revision history. We do have one button so there will be one revision history entry.

What if the summary is too long will we loose crucial information?
Wouldn't it be good if I could revert some parts of the edit and not be forced to revert everything?
daniel added a comment.Jan 10 2018, 3:03 PM
In T173744#3889882, @Jonas wrote:

What if the summary is too long will we loose crucial information?

This should no longer be an issue. At least technically, we now have 64k text plus 64k JSON for the commit message.

Wouldn't it be good if I could revert some parts of the edit and not be forced to revert everything?

Not using the one-click "revert" feature - that reverts the entire edit, by definitions. You can always do partial reverts manually.
WMDE-leszek subscribed.Jan 16 2018, 4:11 PM
Lucas_Werkmeister_WMDE closed subtask T178389: Create API for updating Form descriptions as Resolved.Feb 6 2018, 1:06 PM
Lydia_Pintscher closed this task as Resolved.Feb 13 2018, 2:13 PM
Liuxinyu970226 unsubscribed.Feb 17 2018, 3:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL