Maniphest T198459

Characters appear after a delay when typing in large article translation
Closed, ResolvedPublic

Actions

Assigned To

Authored By

	• santhosh
	Jun 29 2018, 8:59 AM

Description

In the translation of large articles, such as en:Paris, typing has a very delayed response, and page appears hanged in between keypresses.

Details

Subject	Repo	Branch	Lines +/-
Improve section alignment performance	mediawiki/extensions/ContentTranslation	master	+17 -8
Improve section alignment performance	mediawiki/extensions/ContentTranslation	master	+15 -8
Use debounce to align section pairs instead of throttle	mediawiki/extensions/ContentTranslation	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned In: T198789: Every odd section has too small "Add translation" placeholder

Event Timeline

• santhosh created this task.Jun 29 2018, 8:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2018, 8:59 AM

A performance analys shows section aligment causes the pauses in the responsiveness

• santhosh claimed this task.Jun 29 2018, 9:00 AM

• santhosh triaged this task as High priority.

• santhosh added a project: Language-2018-Apr-June.

Change 443051 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Use debounce to align section pairs instead of throttle

https://gerrit.wikimedia.org/r/443051

gerritbot added a project: Patch-For-Review.Jun 29 2018, 9:01 AM

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-Apr-June board.Jun 29 2018, 9:06 AM

• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.

Change 443058 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Improve section alignment performance

https://gerrit.wikimedia.org/r/443058

Change 443051 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use debounce to align section pairs instead of throttle

https://gerrit.wikimedia.org/r/443051

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 2 2018, 9:00 AM

Change 443058 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Improve section alignment performance

https://gerrit.wikimedia.org/r/443058

• Petar.petkovic removed a project: Patch-For-Review.Jul 4 2018, 8:28 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.

• Petar.petkovic removed a subscriber: gerritbot.

Nikerabbit renamed this task from Characters appear after a delay when typing in larget article translation to Characters appear after a delay when typing in large article translation .Jul 4 2018, 8:36 AM

• Petar.petkovic moved this task from QA to In Progress on the Language-2018-Apr-June board.Jul 4 2018, 2:14 PM

• Petar.petkovic mentioned this in T198789: Every odd section has too small "Add translation" placeholder.Jul 4 2018, 10:08 PM

Change 443943 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Improve section alignment performance

https://gerrit.wikimedia.org/r/443943

gerritbot added a project: Patch-For-Review.Jul 5 2018, 11:07 AM

Pginer-WMF edited projects, added Language-2018-July-September; removed Language-2018-Apr-June.Jul 10 2018, 6:55 AM

Pginer-WMF moved this task from Backlog to In Progress on the Language-2018-July-September board.

• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-July-September board.Jul 11 2018, 10:45 AM

• santhosh moved this task from In Review to QA on the Language-2018-July-September board.Aug 7 2018, 7:13 AM

Checked in cx2 - there is the improvement in performance time for mw.cx.ui.TranslationView.static.alignSectionPair (two samples are below):

Screen Shot 2018-08-10 at 5.43.02 PM.png (265×640 px, 66 KB)

Screen Shot 2018-08-10 at 5.51.03 PM.png (289×920 px, 70 KB)

But there is still a noticeable delay in characters appearing when typing. Such delay is not present in production.

@Pginer-WMF May be there should a more general task for performance evaluation? I am marking this task as Resolved for now.

Steps that were performed for testing:

Start 'New translation' for en:Paris article
Click on any paragraph to translate.
When a paragraph is translated, start typing in the paragraph - the typed characters will appear with a delay.

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Aug 18 2018, 12:55 AM

Change 443943 abandoned by Santhosh:
Improve section alignment performance

Reason:
Need a fresh look into the root causes