Page MenuHomePhabricator

Special:NewPagesFeed "copyvio" potential issue should not have its own section
Closed, ResolvedPublic

Assigned To
Authored By
Novem_Linguae
Nov 12 2023, 8:19 PM
Referenced Files
F41502072: Screenshot from 2023-11-13 12-07-28.png
Nov 13 2023, 11:09 AM
F41502049: Screenshot from 2023-11-13 12-07-55.png
Nov 13 2023, 11:09 AM
F41498335: image.png
Nov 12 2023, 8:21 PM
F41498319: image.png
Nov 12 2023, 8:19 PM
F41498266: image.png
Nov 12 2023, 8:19 PM

Description

Steps to reproduce

What happens?

  • Copyvio warning and link ("Potential issues: Copyvio") is at bottom right

image.png (333×1 px, 56 KB)

What should happen?

  • Delete copyvio warning and link ("Potential issues: Copyvio") at bottom right (gerrit:990383)
  • Add "Copyvio" and link to the spot where the other metadata warnings (potential issues) are displayed, at the top center (gerrit:990383)

Motivation:

  • Simplify the code
  • More intuitive to have similar things together in one place, instead of split between two places

Event Timeline

This comment was removed by MPGuy2824.

"Predicted class" can be moved to the right section then. It would reduce the height taken by each individual section related to a page.

Yeap, could do that and move the blue "Review" button up a bit, to save vertical space. Would basically gain a line.

How does this look @Novem_Linguae @MPGuy2824 (if it looks good, we could throw this in with the existing codex patch probably since it is not a significant shift)

N/A rating, attack page full view Copyvio link, stub
Screenshot from 2023-11-13 12-07-55.png (87×1 px, 17 KB)
Screenshot from 2023-11-13 12-07-28.png (82×631 px, 14 KB)

@Soda. Looks good to me. If needed we can create a new ticket for moving "Predicted class" (MPGuy2824's idea in the comments, doesn't appear in your screenshots).

@Soda. Looks good to me. If needed we can create a new ticket for moving "Predicted class" (MPGuy2824's idea in the comments, doesn't appear in your screenshots).

The predicted class should be beside the number of edits to the page in the screenshots

Looks good to me as well. Adding the predicted class next to the number of edits was a good idea. Maybe when you hover over it, it can say "Predicted class".

Change 990382 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Group similar HTML elements together

https://gerrit.wikimedia.org/r/990382

Change 990383 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Combine two problem chips sections

https://gerrit.wikimedia.org/r/990383

Change 990382 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Group similar HTML elements together

https://gerrit.wikimedia.org/r/990382

Change 990383 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Combine two problem chips sections

https://gerrit.wikimedia.org/r/990383

Changing the link to red is not yet done

On second look, I think the red chip is enough red. Keeping the blue hyperlink should be OK now that we have a big red chip.