Page MenuHomePhabricator

Impact Module: Views on articles you've edited graph
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • View the impact module's "Views on articles you've edited" graph

What happens?:
The graph seems to be broken, at least for some users:

Screenshot 2023-11-29 at 4.10.14 PM.png (172×604 px, 22 KB)
https://en.wikipedia.org/wiki/Special:Impact/Eetzie

Screenshot 2023-11-29 at 4.10.53 PM.png (152×840 px, 14 KB)
https://test.wikipedia.org/wiki/Special:Impact/SGimeno_(WMF)

What should have happened instead?:

Graph should display a more cumulative pageview sparkline, as outline in design requirements.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information I can replicate on enwiki and test wiki. I can replicate on Chrome and Safari.

For certain other users, the Impact module was empty, with the following error in console:

TypeError: Cannot convert undefined or null to object
  at Function.assign (<anonymous>)
  at useUserImpact.js:67:18
  at Array.map (<anonymous>)
  at quantizeViews

See T352352 description for more details.

Event Timeline

KStoller-WMF moved this task from Inbox to Backlog on the Growth-Team board.

Change 979097 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: sort datestring keys to ascending alphanumeric order

https://gerrit.wikimedia.org/r/979097

Sgs edited projects, added Growth-Team (Sprint 4 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 4 (Growth Team)) board.

Provided a fix for this, see more details in parent task.

Change 979097 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: sort datestring keys to ascending alphanumeric order

https://gerrit.wikimedia.org/r/979097

Change 979690 had a related patch set uploaded (by Urbanecm; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.7] User impact: sort datestring keys to ascending alphanumeric order

https://gerrit.wikimedia.org/r/979690

Change 979690 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.7] User impact: sort datestring keys to ascending alphanumeric order

https://gerrit.wikimedia.org/r/979690

Mentioned in SAL (#wikimedia-operations) [2023-12-04T12:25:44Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:979690|User impact: sort datestring keys to ascending alphanumeric order (T352349 T351898)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-04T12:28:19Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:979690|User impact: sort datestring keys to ascending alphanumeric order (T352349 T351898)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-12-04T12:35:28Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:979690|User impact: sort datestring keys to ascending alphanumeric order (T352349 T351898)]] (duration: 09m 43s)

This should be fixed in production. It is possible there are still users where the impact module is empty (we will need to investigate further on that).

Change 980030 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: update quantizeViews to process small series of view data

https://gerrit.wikimedia.org/r/980030

This should be fixed in production. It is possible there are still users where the impact module is empty (we will need to investigate further on that).

The origin is most probably at the quantizeViews function in useUserImpact.js which is not properly handling small sets of page views (> 6, < 11 ). Aside from that bug I've noticed the API response for user impact sometimes includes 0-views data points and sometimes it does not, not sure if it's worth investigating since that should not cause any harm.

Change 980030 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: update quantizeViews to process small series of view data

https://gerrit.wikimedia.org/r/980030

Change 979698 had a related patch set uploaded (by Urbanecm; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.7] User impact: update quantizeViews to process small series of view data

https://gerrit.wikimedia.org/r/979698

Change 979698 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.7] User impact: update quantizeViews to process small series of view data

https://gerrit.wikimedia.org/r/979698

Mentioned in SAL (#wikimedia-operations) [2023-12-05T14:23:51Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:979698|User impact: update quantizeViews to process small series of view data (T352349)]], [[gerrit:979700|Add maintenance script to import existing files to scan table (T350863)]], [[gerrit:979701|Only allow drawing and bitmap media types to be scanned (T352234)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-05T14:25:08Z] <urbanecm@deploy2002> kharlan and urbanecm: Backport for [[gerrit:979698|User impact: update quantizeViews to process small series of view data (T352349)]], [[gerrit:979700|Add maintenance script to import existing files to scan table (T350863)]], [[gerrit:979701|Only allow drawing and bitmap media types to be scanned (T352234)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

This should now (once scap finishes scaping) be fixed in WMF production.

Mentioned in SAL (#wikimedia-operations) [2023-12-05T14:32:47Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:979698|User impact: update quantizeViews to process small series of view data (T352349)]], [[gerrit:979700|Add maintenance script to import existing files to scan table (T350863)]], [[gerrit:979701|Only allow drawing and bitmap media types to be scanned (T352234)]] (duration: 08m 55s)