Page MenuHomePhabricator

Remove language move notice from Vector 2022 skin
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
ovasileva
Dec 18 2023, 9:30 AM
Referenced Files
F42455667: screenshot 683.png
Mar 8 2024, 4:52 AM
F42455666: screenshot 682.png
Mar 8 2024, 4:52 AM
F42455648: screenshot 681.png
Mar 8 2024, 4:51 AM
F42455647: screenshot 680.png
Mar 8 2024, 4:51 AM
Tokens
"Like" token, awarded by aliu."Love" token, awarded by Iniquity.

Description

Background

We introduced the notice "Language links are at the top of the page." after the introduction of the new location of the language switcher. This was done in order to make it easier for users to learn the new location of the language switcher if they were in the habit of switching at the previous location. We are now ready to remove this notice

Acceptance criteria

  • Remove the Languages section of the main menu
  • Remove the "Language links are at the top of the page." notice

Developer checklist

  • Make sure includes/Components/VectorComponentMainMenuActionLanguageSwitchAlert.php is removed.
  • Remove any related styles

QA Results - Beta

AC Status Details
1 T353619#9614168
2 T353619#9614168

QA Results - Prod

AC Status Details
1 T353619#9614173
2 T353619#9614173

Details

Event Timeline

Thanks! I started a discussion here on en.wp, please leave a note there when resolving this :)

ovasileva raised the priority of this task from Medium to High.Feb 12 2024, 6:53 PM

Change 1006577 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove language notice

https://gerrit.wikimedia.org/r/1006577

bwang removed bwang as the assignee of this task.Feb 26 2024, 8:00 PM
bwang subscribed.
Jdlrobson lowered the priority of this task from High to Medium.Feb 29 2024, 5:55 PM
bwang removed bwang as the assignee of this task.Feb 29 2024, 6:45 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.

Hello @ovasileva,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

Change 1006577 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove language notice

https://gerrit.wikimedia.org/r/1006577

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Remove the Languages section of the main menu
✅ AC2: Remove the "Language links are at the top of the page." notice

screenshot 680.png (934×1 px, 329 KB)

screenshot 681.png (1×1 px, 261 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Remove the Languages section of the main menu
✅ AC2: Remove the "Language links are at the top of the page." notice

screenshot 682.png (1×1 px, 274 KB)

screenshot 683.png (1×1 px, 624 KB)

ovasileva claimed this task.

Isn’t this a bit too early? There are wikis that aren’t on Vector 2022 yet, will readers of those wikis never see the hint?

aliu subscribed.

I doubt that these wikis have never used the English Wikipedia.

“[T]hese wikis have never used the English Wikipedia” doesn’t make sense: it’s people who used or haven’t used the English Wikipedia, not wikis. And believe it or not, there are many people on the world who don’t speak English. If someone speaks only German and Finnish, why would they use anything other than the German and Finnish Wikipedia?

Good point. I feel like the blue, prominent drop-down with "Languages" in the title is prominent enough, though.

If it’s prominent enough, the notice was unnecessary on enwiki as well. It’s not impossible (we’re all humans, whoever decided to introduce it could have made a mistake), but I assume there was research that showed it’s not prominent enough.