EntitySchema daily CI broken and emails broken
Open, Needs TriagePublic

Actions

Assigned To

None

Authored By

	Michael
	Dec 22 2023, 5:40 PM

Description

The last succeeding run had:

+ cd ..
+ mkdir -p /home/runner/work/mediawiki-extensions-EntitySchema/mediawiki-extensions-EntitySchema/logs
+ cd mediawiki
+ composer phpunit:entrypoint -- extensions/EntitySchema/tests/phpunit/
++ pwd
+ php -S 127.0.0.1:8080 -t /home/runner/work/mediawiki-extensions-EntitySchema
> phpunit '-c' 'tests/phpunit/suite.xml' 'extensions/EntitySchema/tests/phpunit/'
Using PHP 7.4.33
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

The first failing run has

+ cd ..
+ mkdir -p /home/runner/work/mediawiki-extensions-EntitySchema/mediawiki-extensions-EntitySchema/logs
+ cd mediawiki
+ composer phpunit:entrypoint -- extensions/EntitySchema/tests/phpunit/
++ pwd
+ php -S 127.0.0.1:8080 -t /home/runner/work/mediawiki-extensions-EntitySchema
> phpunit 'extensions/EntitySchema/tests/phpunit/'
PHP Fatal error:  Uncaught Error: Class 'MediaWikiIntegrationTestCase' not found in /home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/tests/phpunit/integration/API/UndoAPITest.php:23
Stack trace:

The root cause and fix are probably going to be similar to T353957: [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023). Same for the email not working.

Acceptance criteria

EntitySchema daily CI is green again
email works again, in a more reliable way somehow

Notes:

unrelatedly, GitHub also seems to have skipped a couple of runs?

see https://github.com/wikimedia/mediawiki-extensions-EntitySchema/actions

Details

	Subject	Repo	Branch	Lines +/-
	Fix daily CI on GitHub by actually cloning MediaWiki	mediawiki/extensions/EntitySchema	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: T359188: Chore: Update dependencies in EntitySchema
T353957: [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)

Event Timeline

Michael created this task.Dec 22 2023, 5:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2023, 5:40 PM

Change 987955 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Fix daily CI on GitHub by actually cloning MediaWiki

https://gerrit.wikimedia.org/r/987955

gerritbot added a project: Patch-For-Review.Jan 5 2024, 11:08 AM

Michael added a project: Wikidata Dev Team (Wikidata.org Slice).Jan 5 2024, 11:15 AM

Michael moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Jan 5 2024, 11:29 AM

Change 987955 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Fix daily CI on GitHub by actually cloning MediaWiki

https://gerrit.wikimedia.org/r/987955

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 2:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 8 2024, 4:01 PM

CI is working again, and IIUC we also fixed email sending for the time being, by turning a Google setting that permits sending emails back on. But the setting turns itself off when not used, and because we only rarely send emails from this workflow, we’ll keep running into this issue. (Do we already have a separate task for that?)

Which google setting is it? How long until it turns itself back off?

ItamarWMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 22 2024, 1:19 PM

In T353960#9476589, @ItamarWMDE wrote:

Which google setting is it? How long until it turns itself back off?

Based on https://mattermost.wikimedia.de/swe/pl/z85p3qcdobf33dhxy9nknwfsjo the following sentence:

Because less secure apps can make your account more vulnerable, Google will automatically turn this setting off if it’s not being used.

used to be written on https://support.google.com/accounts/answer/6010255#zippy=%2Cif-less-secure-app-access-is-on-for-your-account

However, not that copy seems to have changed again and now features this warning:

Starting in Fall of 2024, less secure apps, third-party apps, or devices that have you sign in with only your username and password will no longer be supported for Google Workspace accounts. For exact dates, visit Google Workspace Updates.To continue to use a specific app with your Google Account, you’ll need to use a more secure type of access that doesn’t share password data.

So finding a more reliable way to sent emails from a script is a hard requirement. As explained in the mattermost thread, one possible option would be to use WMDE's own infrastructure for that in coordination with our internal IT. I do not know whether our Engineering Managers have acted upon that in way.

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptJan 22 2024, 2:57 PM

I just tested email sending for T359188 (Gerrit change and it’s already broken again (actions run):

Error: Invalid login: 535-5.7.8 Username and Password not accepted. For more information, go to
535 5.7.8 https://support.google.com/mail/?p=BadCredentials mi16-20020a170902fcd000b001dd578121d4sm1664871plb.204 - gsmtp

EntitySchema daily CI broken and emails broken Open, Needs TriagePublic Actions

Description

Details

Related Objects

Event Timeline

EntitySchema daily CI broken and emails broken
Open, Needs TriagePublic

Actions