jquery.cookie alias removed in MediaWiki 1.42
Open, Needs TriagePublic

Actions

Assigned To

None

Authored By

	Jdlrobson
	Jan 12 2024, 6:12 PM

Description

The jquery.cookie ResourceLoader Resource Loader module was merged with the mediawiki.cookie ResourceLoader module in June 2023 (T271995). When we did this we retained an alias to support gadgets referencing the old ResourceLoader module. The deprecation has followed the Frontend stable policy.

The alias will be removed next week via the MediaWiki deployment train (Week Jan 15-19th): T338637.

To avoid disruption, a script was run to migrate impacted code we detected. Here is an example:
If the script missed your code https://meta.wikimedia.org/w/index.php?title=User:He7d3r/Tools.js&diff=prev&oldid=26055575
We were unable to patch minified JS.
This is an FYI. For most editors no action is needed, but if you suspect your script is one of the 18 broken by this change you can see this URL for confirmation: https://global-search.toolforge.org/?q=%5B%22%27%5Djquery%5C.cookie%5B%22%27%5D&regex=1&namespaces=2%2C8&title=.*%5C.js

If you do encounter issues with scripts that might be related the solution is to replace code referencing the string 'jquery.cookie' with the string 'mediawiki.cookie'

Feel free to ask questions here.

Details

	Subject	Repo	Branch	Lines +/-
	Swap uses of the deprecated RL module (alias) jquery.cookie to mediawiki.cookie	mediawiki/extensions/ArticleFeedbackv5	master	+35 -20

Customize query in gerrit

Related Objects

Mentioned In: T338637: Remove jquery.cookie module in MediaWiki 1.42.0
Mentioned Here: T271995: Merge jquery.cookie and mediawiki.cookie modules
T338637: Remove jquery.cookie module in MediaWiki 1.42.0

Event Timeline

Jdlrobson created this task.Jan 12 2024, 6:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2024, 6:12 PM

Jdlrobson moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jan 12 2024, 6:12 PM

Jdlrobson mentioned this in T338637: Remove jquery.cookie module in MediaWiki 1.42.0.

SToyofuku-WMF subscribed.Jan 12 2024, 6:33 PM

Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jan 12 2024, 7:52 PM

Jdlrobson updated the task description. (Show Details)Jan 12 2024, 8:45 PM

When looking for usage on huwiki, I found https://hu.wikiquote.org/wiki/MediaWiki:Common.js, which uses $.cookie. It’s not minified, not obfuscated in any way, just uses the usual $ alias. Please fix those as well before the deploy train reaches the affected wikis.

While usage of mw.cookie is recommended over $.cookie, the latter has not been removed for now, only the jquery.cookie ResourceLoader module alias so https://hu.wikiquote.org/wiki/MediaWiki:Common.js is not impacted by this change.

e.g.

Won't work	Will work
`mw.loader.using('jquery.cookie').then(()=> $.cookie('foo', 'bar' ))`	`mw.loader.using('mediawiki.cookie').then(()=> $.cookie('foo', 'bar' ))`

Jdlrobson updated the task description. (Show Details)Jan 16 2024, 6:34 PM

Okay, thanks for the clarification. However, please note that not everyone uses single quotes, so you should search for double quotes as well: https://global-search.toolforge.org/?q=%5B%22%27%5Djquery%5C.cookie%5B%22%27%5D&regex=1&namespaces=2%2C8&title=.*%5C.js. (Plus usage in MediaWiki:Gadgets-definition, and exotic patterns like template strings, string concatenation etc. – but these exotic patterns are nearly impossible to find and on the other hand should be very rare.)

Jdlrobson updated the task description. (Show Details)Jan 16 2024, 11:44 PM

Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jan 19 2024, 12:45 AM

Change 995439 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/ArticleFeedbackv5@master] Swap uses of the deprecated RL module (alias) jquery.cookie to mediawiki.cookie

https://gerrit.wikimedia.org/r/995439

gerritbot added a project: Patch-For-Review.Feb 3 2024, 2:05 PM

Change 995439 merged by jenkins-bot: