Page MenuHomePhabricator

Migrate MediaWiki.edit.failures.* to statslib
Closed, ResolvedPublic

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.edit.failures.*.rate
  • MediaWiki.edit.failures.conflict
  • MediaWiki.edit.failures.conflict.resolved
  • MediaWiki.edit.failures.conflict.byUserEdits.*
  • MediaWiki.edit.failures.session_loss
  • MediaWiki.edit.failures.conflict.resolved.byUserEdits.*
  • MediaWiki.edit.failures.conflict.byNamespaceId.*.sum
  • MediaWiki.edit.failures.conflict.byUserEdits.*.sum
  • MediaWiki.edit.failures.conflict.count
  • MediaWiki.edit.failures.conflict.rate
  • MediaWiki.edit.failures.conflict.resolved.byUserEdits.*.sum
  • MediaWiki.edit.failures.conflict.resolved.sum
  • MediaWiki.edit.failures.conflict.sum
  • MediaWiki.edit.failures.session_loss.rate

Dashboards affected:

Event Timeline

Change 1003855 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] editpage: consolidate edit failures stats tracking

https://gerrit.wikimedia.org/r/1003855

colewhite changed the task status from Open to In Progress.Feb 16 2024, 11:06 PM
colewhite claimed this task.

Change 1005529 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/extensions/TwoColConflict@master] update stats to use StatsFactory

https://gerrit.wikimedia.org/r/1005529

Change 1003855 merged by jenkins-bot:

[mediawiki/core@master] editpage: track edit conflicts in edit failures stat

https://gerrit.wikimedia.org/r/1003855

Change 1005529 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] update stats to use StatsFactory

https://gerrit.wikimedia.org/r/1005529

lmata updated the task description. (Show Details)

@colewhite, anything to do there? I think I merged all your patches and this should be covered by now?

Also, I removed the back-compat logic: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1011283 and we can land that patch next week once we're sure the work you did here have properly cooked in production and settled :)