Decommision the Special:MobileDiff page
Closed, ResolvedPublic

Actions

Assigned To

None

Authored By

	Jdlrobson
	Feb 22 2024, 9:41 PM

Description

The Special:MobileDIff was disabled for all users on Feb 20th

The old diff page can now be safely removed which will address longstanding technical debt requests and mean the web team no longer maintains code relating to diffs.

TODO

All code relating to SpecialMobileDiff should be removed
Visiting Special:MobileDiff should redirect to diff URL.

Sign off

Close out or update any tickets relating to the MobileDiff page:

T344658 T345730 T222562 T331648 T281056 T201228 T95883 T331002 T165835 T238507 T199307 T238331

After the code is deployed, remove all traces of MFUseDesktopDiffPage in mediawiki configuration. To be done in T360389.

Details

	Subject	Repo	Branch	Lines +/-
	Decommission Special:MobileDiff page	mediawiki/extensions/MobileFrontend	master	+15 -866

Customize query in gerrit

Related Objects

Mentioned In: T238331: Option for hiding changes should be added to AMC diff display
T238507: MobileFrontend sometimes goes to diff page instead of pending changes review page
T331002: "Show IP" link not shown on Special:History or Special:MobileDiff when using MinervaNeue skin
T214500: After "Thanks" on mobile site no change in color and impossible to click
T298174: Diffs should show change tags at lower resolutions
T201228: Make it possible to reach the page history from mobile diff
T281056: Diffs hard to read in Special:MobileDiff (broken up into per word) as whitespace is considered a delimiter
T222562: Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
T345730: MobileDiff style error when diff engine is php
T344658: Bad revision error when MobileDiff is provided the same oldid and diff number
T360389: Cleanup code relating to non-existent MobileDiff page
T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps
T290440: imported> on diff page should not link to contributions on Mobile view
T354840: mobilediff coloring does not match the header definitions
T90948: Identify the best diff style (mobile or desktop) and use it on both mobile and desktop
T191706: It's not possible to undo/rollback edits from diff on Mobile
T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
T348393: Mobile diff doesn't have review buttons
T350181: Enable desktop diff page on mobile site
Mentioned Here: T199307: Determine treatment for empty lines in diffs
T238331: Option for hiding changes should be added to AMC diff display
T95883: [Task] Investigate how to use different/new diff views for entity diffs on mobile
T165835: RevisionSlider for mobile view
T238507: MobileFrontend sometimes goes to diff page instead of pending changes review page
T331002: "Show IP" link not shown on Special:History or Special:MobileDiff when using MinervaNeue skin
T201228: Make it possible to reach the page history from mobile diff
T222562: Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
T281056: Diffs hard to read in Special:MobileDiff (broken up into per word) as whitespace is considered a delimiter
T331648: Style desktop Minerva diff page to implement mobile diff design update
T344658: Bad revision error when MobileDiff is provided the same oldid and diff number
T345730: MobileDiff style error when diff engine is php
T360389: Cleanup code relating to non-existent MobileDiff page

Event Timeline

Jdlrobson created this task.Feb 22 2024, 9:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2024, 9:41 PM

Jdlrobson triaged this task as High priority.Feb 22 2024, 9:41 PM

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.

Jdlrobson mentioned this in T348393: Mobile diff doesn't have review buttons.

Jdlrobson mentioned this in T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).Feb 22 2024, 9:47 PM

matmarex subscribed.Feb 22 2024, 10:23 PM

Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Feb 22 2024, 10:31 PM

Jdlrobson mentioned this in T191706: It's not possible to undo/rollback edits from diff on Mobile.

Jdlrobson mentioned this in T90948: Identify the best diff style (mobile or desktop) and use it on both mobile and desktop.Feb 23 2024, 2:04 AM

Jdlrobson mentioned this in T354840: mobilediff coloring does not match the header definitions.

Jdlrobson mentioned this in T290440: imported> on diff page should not link to contributions on Mobile view.Feb 23 2024, 2:07 AM

Jdlrobson added a project: patch-welcome.Feb 24 2024, 1:23 AM

Jdlrobson moved this task from Backlog to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 28 2024, 6:09 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (Needs Prioritization (Tech)).Mar 4 2024, 5:05 PM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 7 2024, 3:18 PM

Change 1009788 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Decomission Special:MobileDiff page

https://gerrit.wikimedia.org/r/1009788

gerritbot added a project: Patch-For-Review.Mar 8 2024, 7:28 PM

Jdlrobson mentioned this in T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps.Mar 12 2024, 6:09 PM

Jdlrobson added a project: Web Team Essential Work 2024.Mar 13 2024, 5:22 PM

Jdlrobson moved this task from Backlog to Q3 (Jan-April) on the Web Team Essential Work 2024 board.Mar 13 2024, 5:24 PM

jsn.sherman added a project: Moderator-Tools-Team (Kanban).Mar 18 2024, 7:22 PM

jsn.sherman moved this task from Ready to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.

Change 1009788 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Decommission Special:MobileDiff page

https://gerrit.wikimedia.org/r/1009788

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 10:30 PM

Scardenasmolinar awarded a token.Mar 18 2024, 10:59 PM

Jdlrobson mentioned this in T360389: Cleanup code relating to non-existent MobileDiff page.Mar 18 2024, 11:56 PM

Jdlrobson mentioned this in T344658: Bad revision error when MobileDiff is provided the same oldid and diff number.Mar 19 2024, 12:01 AM

Jdlrobson mentioned this in T345730: MobileDiff style error when diff engine is php.

Jdlrobson mentioned this in T222562: Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions.

Jdlrobson mentioned this in T281056: Diffs hard to read in Special:MobileDiff (broken up into per word) as whitespace is considered a delimiter.Mar 19 2024, 12:04 AM

Jdlrobson mentioned this in T201228: Make it possible to reach the page history from mobile diff.Mar 19 2024, 12:15 AM

Jdlrobson closed this task as Resolved.Mar 19 2024, 12:19 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T298174: Diffs should show change tags at lower resolutions.

Jdlrobson mentioned this in T214500: After "Thanks" on mobile site no change in color and impossible to click.Mar 19 2024, 12:32 AM

Jdlrobson mentioned this in T331002: "Show IP" link not shown on Special:History or Special:MobileDiff when using MinervaNeue skin.

Jdlrobson mentioned this in T238507: MobileFrontend sometimes goes to diff page instead of pending changes review page.Mar 19 2024, 12:41 AM

Jdlrobson updated the task description. (Show Details)Mar 19 2024, 12:47 AM

Jdlrobson mentioned this in T238331: Option for hiding changes should be added to AMC diff display.Mar 19 2024, 12:50 AM