Maniphest T361918

"Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04
Closed, ResolvedPublicBUG REPORT

Actions

Assigned To

Authored By

	Count_Count
	Fri, Apr 5, 9:30 AM

Description

Steps to replicate the issue (include links if applicable):

See dewiki recent changes and e.g. history 1 and history 2. Other wikis such as meta are apparently not affected (meta recent changes).

What happens?:

Reverted main space edits are not tagged.

What should have happened instead?:

Reverted main space edits should be tagged as reverted.

Other information (browser name/version, screenshots, etc.):

Maybe this is related to FlaggedRevisions somehow as only dewiki and only the main namespace seems to be affected?

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Mark all autoreviewed edits in PageSaveComplete hook"	mediawiki/extensions/FlaggedRevs	wmf/1.42.0-wmf.25	+18 -7
	Revert "Mark all autoreviewed edits in PageSaveComplete hook"	mediawiki/extensions/FlaggedRevs	master	+18 -7

Customize query in gerrit

Related Objects

Mentioned In: T361960: The page gets unreviewed when moved to a new address
T361940: Imports, moves and protections are not autoreviewed
T360157: 1.42.0-wmf.25 deployment blockers
Mentioned Here: T361940: Imports, moves and protections are not autoreviewed
T361960: The page gets unreviewed when moved to a new address

Event Timeline

Count_Count created this task.Fri, Apr 5, 9:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Apr 5, 9:31 AM

TenWhile6 subscribed.Fri, Apr 5, 9:32 AM

taavi mentioned this in T360157: 1.42.0-wmf.25 deployment blockers.Fri, Apr 5, 9:34 AM

Ankermast subscribed.Fri, Apr 5, 9:35 AM

Count_Count updated the task description. (Show Details)Fri, Apr 5, 9:43 AM

Aklapper renamed this task from Mw-reverted tag no longer applied in main namespace on German Wikipedia since last night to "Reverted" tag no longer applied in main namespace on German Wikipedia since 2024-04-04.Fri, Apr 5, 10:00 AM

Aklapper added projects: MediaWiki-Recent-changes, Regression.

Restricted Application added a project: Growth-Team. · View Herald TranscriptFri, Apr 5, 10:00 AM

matej_suchanek added a project: MediaWiki-extensions-FlaggedRevs.Fri, Apr 5, 11:00 AM

Johannnes89 subscribed.Fri, Apr 5, 11:40 AM

Can confirm this in template namespace that also has FlaggedRevs activated. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1015176 has changes to FlaggedRevs and reverts but seems unrelated to me at first glance.

There are four changes that got the tag ("Zurückgesetzt" is reverted):

They have in common that the revert had been reviewed manually later, so it seems like the reverted tag doesn't get applied when the edit is autoreviewed.

I could reproduce this on my own edit in https://de.wikipedia.org/w/index.php?title=Fuchs_%28Raubtier%29&diff=243777563&oldid=243777556 by removing the review of the revert manually and then reviewing it again. Now https://de.wikipedia.org/w/index.php?title=Fuchs_(Raubtier)&diff=prev&oldid=243777556 has the reverted tag.

Ladsgroup added a subscriber: matmarex.Fri, Apr 5, 1:45 PM

Johannnes89 mentioned this in T361940: Imports, moves and protections are not autoreviewed.Fri, Apr 5, 2:44 PM

Maybe one of these recent changes is the cause?

Hmm, I don't see how the recent changes to FlaggedRevs could have affected how the mw-reverted tag is applied, since it's a core feature. I will try to reproduce and debug this, hopefully we can fix it on Monday.

Could it be that FlaggedRevs removes the tags applied by core? I saw something in maybeMakeEditReviewed but I don't fully understand everything there.

Indeed. FlaggedRevs prevents the mw-reverted from being applied to reverted edits if the revert is not autoreviewed, and later applies it manually if the revert gets reviewed (I didn't know about this, it's documented here: https://www.mediawiki.org/wiki/Manual:Reverts#FlaggedRevs). My commit https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1015175 changed the order in which things happen, so that when it checks if it should prevent the tag, the edit was not autoreviewed yet, so it always prevented it from applying. I'll submit a revert, and document the code better so that no one repeats my mistake.

Change #1017376 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017376

gerritbot added a project: Patch-For-Review.Fri, Apr 5, 8:47 PM

I'll backport the fix on Monday, I understand that it's a bit annoying for recent changes patrollers, but I don't think that this is critical enough to do right before the weekend.

I also found that there's a workaround – if you un-approve and then approve again the autoreviewed revert edit, the reverted edits will gain the needed mw-reverted change tags. Hope this helps.

matmarex renamed this task from "Reverted" tag no longer applied in main namespace on German Wikipedia since 2024-04-04 to "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04.Fri, Apr 5, 9:03 PM

matmarex added a project: User-notice.

UOzurumba moved this task from To Triage to Not ready to announce on the User-notice board.Fri, Apr 5, 11:29 PM

Change #1017376 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017376

Change #1017890 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017890

Xneb20 subscribed.Mon, Apr 8, 7:48 PM

Change #1017890 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017890

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:09:24Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:11:36Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:25:49Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] (duration: 16m 25s)

matmarex closed this task as Resolved.Mon, Apr 8, 8:39 PM

matmarex removed a project: Patch-For-Review.

Resolved now.

I added a note to Tech News for next week: https://meta.wikimedia.org/w/index.php?title=Tech/News/2024/16&diff=prev&oldid=26569154

Once again, my apologies for causing the problem.

UOzurumba moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Wed, Apr 10, 5:09 PM

UOzurumba moved this task from Already announced/Archive to In current Tech/News draft on the User-notice board.Wed, Apr 10, 5:12 PM

"Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04 Closed, ResolvedPublicBUG REPORT Actions

Description

Details

Related Objects

Event Timeline

"Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04
Closed, ResolvedPublicBUG REPORT

Actions