| Ameisenigel | |
| Fri, Apr 5, 1:29 PM |
Steps to replicate the issue: Import a page on a target page that is already existing on a wiki with FlaggedRevs and is currently marked as reviewed.
What happens?: The edit for the import is not autoreviewed (see https://de.wikipedia.org/w/index.php?title=Der_Rikschamann_(1958)&action=history as an example) and needs to be reviewed manually
What should have happened instead?: The edit should be marked as autoreviewed
Change #1017376 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"
The problem that page move was not autoreviewed were reported in finnish wikipedia too. In the report was mentioned that autoreview of page moves was worked on 21:58, 3 April 2024 and in 11:47, 4 April 2024 it was broken.
Huwiki page https://hu.wikipedia.org/wiki/Matthew_McConaughey?stable=0&uselang=en cannot be checked. After "accepting changes" it gets unreviewed over again.
@Bean49 I can confirm the bug (though I'm not sure if it's directly related to this task). I wasn't able to review the article as well. But I checked this template edit (Sablon:Screen Actors Guild-díj a legjobb férfi főszereplőnek is transcluded at hu:Matthew McConaughey). After reviewing the template all linked articles no longer show as unreviewed. @Ladsgroup this sounds a bit like T361166.
Doing this will address the problem for everyone regarding that issue: T359529#9684005
Change #1017376 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"
This is a massive change in how autoreview was handled though, if intended. Having one or multiple unreviewed templates on a page shouldn’t lead to requiring to review every single edit on a page.
Accepting changes on (main) page is not required. You shoud see proper message on top, and not the form. You need to accept edit in Template namespace - same way as other unrevieved edits.
Yeah. As Wargo said, it has nothing to do with reviewing edits on the article. You need to review edits of the templates that are used and then that message will go away.
Regardless, out of scope of this ticket.
Change #1017890 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"
Change #1017890 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"
Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:09:24Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]]
Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:11:36Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:25:49Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] (duration: 16m 25s)
Resolved now.
I added a note to Tech News for next week: https://meta.wikimedia.org/w/index.php?title=Tech/News/2024/16&diff=prev&oldid=26569154
Once again, my apologies for causing the problem.