Page MenuHomePhabricator
Projects VisualEditor

VisualEditorUmbrella
ActivePublic
Watch Project

Members (29)

Watchers (22)

Details

Source Repo
https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor
Description

VisualEditor is a project to create a reliable, full-featured rich-text or "visual" HTML editor for the Web. Though VisualEditor itself is an HTML editor, it is integrated into platforms for use there, primary in MediaWiki-General with the VisualEditor-MediaWiki integration, used in conjunction with the Parsoid parsing service to provide the HTML+RDFa.

Our projects are arranged as follows:

  • VisualEditor – Anything related to VisualEditor, including related extensions.

Recent Activity
View All

Today

Maintenance_bot removed a project from T351550: TypeError: Cannot read properties of undefined (reading 'getAttribute') in ve.ui.MWReferenceSearchWidget.buildIndex : Patch-For-Review.
Tue, Apr 30, 11:30 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), VisualEditor-MediaWiki-References, VisualEditor, Citoid, Wikimedia-production-error
ReleaseTaggerBot added a project to T351550: TypeError: Cannot read properties of undefined (reading 'getAttribute') in ve.ui.MWReferenceSearchWidget.buildIndex : MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).
Tue, Apr 30, 11:00 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), VisualEditor-MediaWiki-References, VisualEditor, Citoid, Wikimedia-production-error
gerritbot added a comment to T351550: TypeError: Cannot read properties of undefined (reading 'getAttribute') in ve.ui.MWReferenceSearchWidget.buildIndex .

Change #1018175 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add safe-guard to ReferenceSearchWidget.buildIndex

https://gerrit.wikimedia.org/r/1018175

Tue, Apr 30, 10:38 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), VisualEditor-MediaWiki-References, VisualEditor, Citoid, Wikimedia-production-error
awight added a comment to T351550: TypeError: Cannot read properties of undefined (reading 'getAttribute') in ve.ui.MWReferenceSearchWidget.buildIndex .

(Let's keep this task and solve the root issue after the production error is worked-around.)

Tue, Apr 30, 10:16 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), VisualEditor-MediaWiki-References, VisualEditor, Citoid, Wikimedia-production-error
ReleaseTaggerBot added a project to T363096: [Refactor] Get rid of "auto/<#>" and "literal/<name>" internal ref IDs: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).
Tue, Apr 30, 10:00 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), WMDE-TechWish-Sprint-2024-04-24, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-References, WMDE-TechWish-Maintenance, WMDE-TechWish-Sprint-2024-04-12, Cite
gerritbot added a comment to T363096: [Refactor] Get rid of "auto/<#>" and "literal/<name>" internal ref IDs.

Change #1023843 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop unused setters from MWReferenceModel class

https://gerrit.wikimedia.org/r/1023843

Tue, Apr 30, 9:48 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), WMDE-TechWish-Sprint-2024-04-24, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-References, WMDE-TechWish-Maintenance, WMDE-TechWish-Sprint-2024-04-12, Cite
gerritbot added a comment to T363096: [Refactor] Get rid of "auto/<#>" and "literal/<name>" internal ref IDs.

Change #1023842 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Mark private MWReferenceModel setters as such

https://gerrit.wikimedia.org/r/1023842

Tue, Apr 30, 9:21 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), WMDE-TechWish-Sprint-2024-04-24, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-References, WMDE-TechWish-Maintenance, WMDE-TechWish-Sprint-2024-04-12, Cite
gerritbot added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

Change #1020294 abandoned by Zoe:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Confirms before closing code block dialog if the user has pending changes

Reason:

Moved the change into VE as it's generic https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1025369

https://gerrit.wikimedia.org/r/1020294

Tue, Apr 30, 9:12 AM · Patch-For-Review, VisualEditor

Yesterday

MusikAnimal moved T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.
Mon, Apr 29, 7:33 PM · Patch-For-Review, VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
gerritbot added a project to T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages: Patch-For-Review.
Mon, Apr 29, 7:32 PM · Patch-For-Review, VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
gerritbot added a comment to T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages.

Change #1025449 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] ext.CodeMirror.visualEditor: don't load on RTL pages

https://gerrit.wikimedia.org/r/1025449

Mon, Apr 29, 7:31 PM · Patch-For-Review, VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
Maintenance_bot added a project to T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages: VisualEditor.
Mon, Apr 29, 7:30 PM · Patch-For-Review, VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
ReleaseTaggerBot added a project to T361775: Iconless toggle buttons on diff of the first revision of a page: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).
Mon, Apr 29, 6:00 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023
Maintenance_bot removed a project from T361775: Iconless toggle buttons on diff of the first revision of a page: Patch-For-Review.
Mon, Apr 29, 5:30 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023
gerritbot added a comment to T361775: Iconless toggle buttons on diff of the first revision of a page.

Change #1017270 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Load diff modules in onTextSlotDiffRendererTablePrefix as well

https://gerrit.wikimedia.org/r/1017270

Mon, Apr 29, 5:02 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor, VisualEditor-VisualDiffs, MediaWiki-Page-diffs, Better-Diffs-2023
Maintenance_bot removed a project from T230323: Use MutationObservers to detect structural changes: Patch-For-Review.
Mon, Apr 29, 4:31 PM · Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
Maintenance_bot removed a project from T362333: Instruct developers to set FIREFOX_BIN environment: Patch-For-Review.
Mon, Apr 29, 4:30 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor
Maintenance_bot removed a project from T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown: Patch-For-Review.
Mon, Apr 29, 4:30 PM · VisualEditor
MNeisler reassigned T342930: [MILESTONE] Run an A/B test to evaluate Edit Check (references) impact from MNeisler to • ppelberg.
Mon, Apr 29, 4:13 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), EditCheck, Editing-team, VisualEditor
MNeisler moved T352131: Publish findings from the Edit Check (references) A/B test from Next 2 weeks to Doing on the Product-Analytics (Kanban) board.
Mon, Apr 29, 4:10 PM · Product-Analytics (Kanban), Editing-team (Tracking), EditCheck, VisualEditor
MNeisler moved T342930: [MILESTONE] Run an A/B test to evaluate Edit Check (references) impact from Doing to Needs Review on the Product-Analytics (Kanban) board.

All results and methodology are now summarized in the final report. Please let me know if you have any questions or suggested additions/changes.

Mon, Apr 29, 4:10 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), EditCheck, Editing-team, VisualEditor
ReleaseTaggerBot added a project to T362333: Instruct developers to set FIREFOX_BIN environment: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).
Mon, Apr 29, 4:00 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor
gerritbot added a comment to T250843: Replace jsduck with JSDoc3 in VisualEditor.

Change #1025333 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] docs: Replace JSDuck with JSDoc (and pull-through VE with said change)

https://gerrit.wikimedia.org/r/1025333

Mon, Apr 29, 3:37 PM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
gerritbot added a comment to T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown.

Change #1025333 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] docs: Replace JSDuck with JSDoc (and pull-through VE with said change)

https://gerrit.wikimedia.org/r/1025333

Mon, Apr 29, 3:37 PM · VisualEditor
gerritbot added a comment to T362333: Instruct developers to set FIREFOX_BIN environment.

Change #1025328 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 3:36 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor
gerritbot added a comment to T131361: Cursoring off of focused block nodes with shift behaves unexpectedly.

Change #1025328 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 3:36 PM · Patch-For-Review, Editing QA, Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor
gerritbot added a comment to T230323: Use MutationObservers to detect structural changes.

Change #1025328 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 3:36 PM · Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
gerritbot added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

Change #1025384 abandoned by Zoe:

[mediawiki/extensions/VisualEditor@master] Removed the unused 'whitespace' field

Reason:

Conflicts with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/620362 which renders this unnecessary

https://gerrit.wikimedia.org/r/1025384

Mon, Apr 29, 3:31 PM · Patch-For-Review, VisualEditor
Jdforrester-WMF closed T250843: Replace jsduck with JSDoc3 in VisualEditor as Resolved.
Mon, Apr 29, 3:23 PM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
Jdforrester-WMF updated the task description for T250843: Replace jsduck with JSDoc3 in VisualEditor.
Mon, Apr 29, 3:21 PM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
gerritbot added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

Change #1025390 had a related patch set uploaded (by Zoe; author: Zoe):

[mediawiki/extensions/VisualEditor@master] Rename isModified to isSaveable and deprecate the old name.

https://gerrit.wikimedia.org/r/1025390

Mon, Apr 29, 3:18 PM · Patch-For-Review, VisualEditor
AlexisJazz added a comment to T362379: Several major news websites (NYT, NPR, Reuters...) block citoid due to too much traffic.
In T362379#9752545, @Mvolz wrote:
In T362379#9729595, @jeremyb-phone wrote:

besides statistics about which tools have this much volume would you also drop some kind of time series graph dashboard with request volume and error volume? thank you.

https://grafana.wikimedia.org/d/NJkCVermz/citoid?orgId=1&refresh=5m&from=now-30m&to=now

Mon, Apr 29, 3:14 PM · VisualEditor, Citoid
gerritbot added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

Change #1025384 had a related patch set uploaded (by Zoe; author: Zoe):

[mediawiki/extensions/VisualEditor@master] Removed the unused 'whitespace' field

https://gerrit.wikimedia.org/r/1025384

Mon, Apr 29, 2:58 PM · Patch-For-Review, VisualEditor
gerritbot added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

Change #1025369 had a related patch set uploaded (by Zoe; author: Zoe):

[mediawiki/extensions/VisualEditor@master] Confirm abort if saving would make a change to the underlying document

https://gerrit.wikimedia.org/r/1025369

Mon, Apr 29, 2:01 PM · Patch-For-Review, VisualEditor
Samwalton9-WMF updated the task description for T362379: Several major news websites (NYT, NPR, Reuters...) block citoid due to too much traffic.
Mon, Apr 29, 1:03 PM · VisualEditor, Citoid
Samwalton9-WMF added a comment to T362379: Several major news websites (NYT, NPR, Reuters...) block citoid due to too much traffic.
In T362379#9747293, @Mvolz wrote:
In T362379#9729558, @Samwalton9-WMF wrote:
In T362379#9729541, @Mvolz wrote:

The NYTimes has been blocking us for a while, it briefly worked when we changed datacenters and ergo IP, but they've understandably reblocked us after a few weeks' reprieve!

There's not a whole lot we can do except to ask for IP exemptions - @Samwalton9-WMF would this be something partnerships could try?

Possibly! It's easiest in cases where The Wikipedia Library has an ongoing dialogue, as is the case with Elsevier, who we're currently talking with about this issue.

This is partly a consequence of the fact that over the last few years our traffic has increased a lot, we didn't used to trigger IP blocks as often.

A possible solution would be to close off the API, but that would mean we'd no longer support things like reftoolbar.

We may also want to look into adding blacklists for websites who have expressed they definitely do not want us accessing them to be respectful of that.

Could we set up a system whereby API keys are manually distributed for tools which are going to be used on Wikimedia projects? I'd hope we could find a middle ground between 'fully open' and 'fully closed'. Unless of course tools like reftoolbar are the primary culprit of this increased traffic.

We could model ourselves after the crossRef API: https://www.crossref.org/documentation/retrieve-metadata/rest-api/tips-for-using-the-crossref-rest-api/

The issue of having api keys and giving them to reftoolbar is there is no way to store secrets on wiki! It's not private in the least. It would end up being security via obscurity and trusting that people a) don't either steal the publicly viewable key or b) use the toolforge service which uses the key. Which, might be enough, really. But if we are still letting people other than for on wiki stuff on purpose, it's still going to be an issue.

Mon, Apr 29, 1:00 PM · VisualEditor, Citoid
gerritbot added a project to T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown: Patch-For-Review.
Mon, Apr 29, 12:04 PM · VisualEditor
gerritbot added a comment to T250843: Replace jsduck with JSDoc3 in VisualEditor.

Change #1025333 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] docs: Replace JSDuck with JSDoc (and pull-through VE with said change)

https://gerrit.wikimedia.org/r/1025333

Mon, Apr 29, 12:04 PM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
gerritbot added a comment to T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown.

Change #1025333 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] docs: Replace JSDuck with JSDoc (and pull-through VE with said change)

https://gerrit.wikimedia.org/r/1025333

Mon, Apr 29, 12:03 PM · VisualEditor
gerritbot added a project to T131361: Cursoring off of focused block nodes with shift behaves unexpectedly: Patch-For-Review.
Mon, Apr 29, 11:36 AM · Patch-For-Review, Editing QA, Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor
gerritbot added a project to T230323: Use MutationObservers to detect structural changes: Patch-For-Review.
Mon, Apr 29, 11:34 AM · Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
gerritbot added a comment to T362333: Instruct developers to set FIREFOX_BIN environment.

Change #1025328 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 11:34 AM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), VisualEditor
gerritbot added a comment to T230323: Use MutationObservers to detect structural changes.

Change #1025328 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 11:34 AM · Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
gerritbot added a comment to T131361: Cursoring off of focused block nodes with shift behaves unexpectedly.

Change #1025328 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to f428c59fadb27b0cdd79830eb3db79ccd30b2d82

https://gerrit.wikimedia.org/r/1025328

Mon, Apr 29, 11:34 AM · Patch-For-Review, Editing QA, Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor
Maintenance_bot removed a project from T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown: Patch-For-Review.
Mon, Apr 29, 11:30 AM · VisualEditor
Jdforrester-WMF updated the task description for T250843: Replace jsduck with JSDoc3 in VisualEditor.
Mon, Apr 29, 11:29 AM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
gerritbot added a comment to T363329: Calling ve.dm.Document#rebuildTree causes an exception to be thrown.

Change #1023851 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Clear branch node cache when rebuilding tree

https://gerrit.wikimedia.org/r/1023851

Mon, Apr 29, 11:27 AM · VisualEditor
gerritbot added a comment to T250843: Replace jsduck with JSDoc3 in VisualEditor.

Change #601861 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] build: Replace jsduck with jsdoc for documentation

https://gerrit.wikimedia.org/r/601861

Mon, Apr 29, 11:11 AM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
zoe added a comment to T334513: Code block dialog should not close on Escape if there are unsaved changes.

I have a patch ready for this specific plugin. However, it made sense to move this change over to the VE codebase such that any plugin that creates a dialog can benefit from the check for unsaved changes. I'll be submitting that shortly for feedback.

Mon, Apr 29, 10:52 AM · Patch-For-Review, VisualEditor
Mvolz added a comment to T362379: Several major news websites (NYT, NPR, Reuters...) block citoid due to too much traffic.
In T362379#9729595, @jeremyb-phone wrote:

besides statistics about which tools have this much volume would you also drop some kind of time series graph dashboard with request volume and error volume? thank you.

Mon, Apr 29, 10:41 AM · VisualEditor, Citoid
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL