| Jdlrobson | |
| Feb 7 2024, 10:17 PM |
| F41832502: screenshot 228.mov.gif | |
| Feb 9 2024, 11:03 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Link is now black
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
https://phabricator.wikimedia.org/T356928#9530669
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T356928#9530669 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Jdrewniak | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Open | Jdrewniak | T341632 [EPIC] Palette customizations and dark mode | |||
| Open | None | T354835 [epic] Release night mode as a beta feature on desktop and mobile | |||
| Open | None | T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release | |||
| Open | None | T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile | |||
| Resolved | Jdlrobson | T356074 Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties | |||
| Resolved | BUG REPORT | Jdlrobson | T356928 Regression: Visited links on mobile appearing as black |
Change 998594 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] color-link-visited was not defined
Change 998594 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] color-link-visited was not defined
Can someone please fix this? As an editor who edits on the mobile site, this is a serious problem. It makes it very hard to figure out what is and is not linked. Several times today I have opened the edit menu to add a link, only to discover that said link was already there.
Change 998974 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] color-link-visited was not defined
I discovered this issue about an hour or so ago, and started the following discussion on Enwiki:
Note: local workaround added in enwiki to https://en.wikipedia.org/wiki/MediaWiki:Minerva.css
Change 998974 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] color-link-visited was not defined
Mentioned in SAL (#wikimedia-operations) [2024-02-09T16:57:50Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:998974|color-link-visited was not defined (T356928)]]
Mentioned in SAL (#wikimedia-operations) [2024-02-09T16:59:20Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 jdlrobson and lucaswerkmeister-wmde: Backport for [[gerrit:998974|color-link-visited was not defined (T356928)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-02-09T17:11:04Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:998974|color-link-visited was not defined (T356928)]] (duration: 13m 13s)
Status: ✅ PASS
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Visit https://m.mediawiki.org/wiki/MediaWiki or
Open , multilingual in a new tab
Refresh page
✅ AC1: Link should not be black and should show as visited.
Change 1008978 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Rename `--color-link--visited` to `--color-visited`
Change 1008978 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Rename `--color-link--visited` to `--color-visited`
Change 1008986 had a related patch set uploaded (by Stoyofuku-wmf; author: Jdrewniak):
[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.21] Rename `--color-link--visited` to `--color-visited`
Change 1008986 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.21] Rename `--color-link--visited` to `--color-visited`
Mentioned in SAL (#wikimedia-operations) [2024-03-06T09:52:39Z] <jnuche@deploy2002> Started scap: Backport for [[gerrit:1008986|Rename --color-link--visited to --color-visited (T356928)]]
Mentioned in SAL (#wikimedia-operations) [2024-03-06T09:56:39Z] <jnuche@deploy2002> jnuche and toyofuku: Backport for [[gerrit:1008986|Rename --color-link--visited to --color-visited (T356928)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-03-06T10:08:15Z] <jnuche@deploy2002> Finished scap: Backport for [[gerrit:1008986|Rename --color-link--visited to --color-visited (T356928)]] (duration: 15m 35s)