| Samwilson | |
| Fri, Apr 19, 12:42 AM |
| F49310530: T362943_AutoSuggest_SafariIssue1.webm | |
| Mon, Apr 29, 4:08 PM |
| F49310510: T362943_AutoSuggest_SafariIssue.webm | |
| Mon, Apr 29, 4:08 PM |
| F48118971: T362943_AS_LinkEdit_Safari.webm | |
| Mon, Apr 22, 4:53 PM |
| F48118856: T362943_AS_LinkEdit_FF.webm | |
| Mon, Apr 22, 4:53 PM |
| F48118833: T362943_AS_LinkEdit_Chrome.webm | |
| Mon, Apr 22, 4:53 PM |
Currently, after saving any page that is linked to Wikidata, the dialog is shown (with the "This article is already linked to an item." message). This is disruptive and doesn't really help anything.
For any page that is already linked, the postEdit dialog should not be displayed.
This bug was introduced after the postEdit behaviour was fixed recently.
Task Description:
| AC | Status | Details |
|---|---|---|
| 1 | ❌ | https://phabricator.wikimedia.org/T362943 here |
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Do not show dialog automatically after saving a linked page | repos/commtech/autosuggest-sitelink!58 | samwilson | avoid-postedit | main |
@Samwilson Chrome and Firefox seem to be working fine but please review the Safari issue below and let me know what you think.
Status: ❌ Fail
Environment: En Wiki Prod
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.org/wiki/Th%E1%BA%A9m_Khuy%C3%AAn_Cave
✅AC1: https://phabricator.wikimedia.org/T362943
| Chrome | FireFox |
❌Issue-Safari is having an issue when clicking the AutosuggestSiteLink the first time. It just hangs until you push it a 2nd time as seen in the video below.
samwilson opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/58
Do not show dialog automatically after saving a linked page
musikanimal merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/58
Do not show dialog automatically after saving a linked page
❌Issue-Safari is having an issue when clicking the AutosuggestSiteLink the first time. It just hangs until you push it a 2nd time as seen in the video below.
@GMikesell-WMF I'm not able to replicate this. It does look like there's some slowness somewhere, in that the link is supposed to grey out only while it loads the required code, and then only start searching Wikidata after the dialog has opened. A couple of questions:
It doesn't look like it's an issue with the actual click, because it's greying out the link correctly. It could perhaps be something going wrong with fetching or parsing the translations, because it does that after the click (you should see it make a request to something like https://meta.wikimedia.org/w/api.php?action=query&format=json&prop=revisions&titles=MediaWiki%3AGadget-AutosuggestSitelink-messages%2Fen&rvprop=content&rvslots=main&formatversion=2 i.e. a URL containing MediaWiki:Gadget-AutosuggestSitelink-messages/en).
@Samwilson Please see remarks below.
- what happens if you wait longer?
I waited for over a minute after clicking, which nothing happened
- can you open the web browser dev console and see if there are any error messages?
It looks like I get an "Unhandled Promise Rejection: badtoken when I first click on it in Safari as seen in the 1st video
- also in the console, but in the network tab, do you see it make any requests to load.php after you click?
Yes, as seen in the 2nd video.
AutosuggestSiteLink Issue- This only happens when I click on it the first time in Safari.
| Console Tab | Network Tab |